Issue #5275: In Cookie's Cookie.load(), properly handle non-string arguments as documented.

2009-09-04 08:17:04 +00:00 · 2009-09-04 08:17:04 +00:00 · d22b9519d1
parent fe18a11858
commit d22b9519d1
2 changed files with 6 additions and 1 deletions
--- a/Lib/Cookie.py
+++ b/Lib/Cookie.py
@ -624,7 +624,9 @@ class BaseCookie(dict):
        if type(rawdata) == type(""):
            self.__ParseString(rawdata)
        else:
-            self.update(rawdata)
+            # self.update() wouldn't call our custom __setitem__
+            for k, v in rawdata.items():
+                self[k] = v
        return
    # end load()

--- a/Misc/NEWS
+++ b/Misc/NEWS
@ -364,6 +364,9 @@ Core and Builtins
 Library
 -------

+- Issue #5275: In Cookie's Cookie.load(), properly handle non-string arguments
+  as documented.
+
 - Issue #2666: Handle BROWSER environment variable properly for unknown browser
  names in the webbrowser module.