Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

#2777: Handle fds more carefully to try to fix some x86-Linux failures (namely, neal bot and twisted bot).

This commit is contained in:
Florent Xicluna 2010-03-05 19:31:21 +00:00
parent 20d7f6e8f4
commit cecef392f1
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
Lib/test/test_subprocess.py
View File

@ -651,7 +651,10 @@ class POSIXProcessTestCase(unittest.TestCase):
self.assertEqual(rc, 47)
def test_send_signal(self):
p = subprocess.Popen([sys.executable, "-c", "input()"])
# Do not inherit file handles from the parent.
# It should fix failures on some platforms.
p = subprocess.Popen([sys.executable, "-c", "input()"], close_fds=True,
stdin=subprocess.PIPE, stderr=subprocess.PIPE)
# Let the process initialize correctly (Issue #3137)
time.sleep(0.1)
@ -672,14 +675,14 @@ class POSIXProcessTestCase(unittest.TestCase):
def test_kill(self):
p = subprocess.Popen([sys.executable, "-c", "input()"])
self.assertIs(p.poll(), None)
self.assertIsNone(p.poll())
p.kill()
self.assertEqual(p.wait(), -signal.SIGKILL)
def test_terminate(self):
p = subprocess.Popen([sys.executable, "-c", "input()"])
self.assertIs(p.poll(), None)
self.assertIsNone(p.poll())
p.terminate()
self.assertEqual(p.wait(), -signal.SIGTERM)