Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

bpo-34436: Fix check that disables overallocation for the last fmt specifier (GH-8826) 

Reported by Svace static analyzer.
This commit is contained in:
Alexey Izbyshev 2018-08-23 10:50:52 +03:00 committed by Victor Stinner
parent 65bef36f0b
commit ccd9975267
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Objects/bytesobject.c
View File

@ -819,8 +819,8 @@ _PyBytes_FormatEx(const char *format, Py_ssize_t format_len,
if (v == NULL)
goto error;
if (fmtcnt < 0) {
/* last writer: disable writer overallocation */
if (fmtcnt == 0) {
/* last write: disable writer overallocation */
writer.overallocate = 0;
}
@ -1048,7 +1048,7 @@ _PyBytes_FormatEx(const char *format, Py_ssize_t format_len,
/* If overallocation was disabled, ensure that it was the last
write. Otherwise, we missed an optimization */
assert(writer.overallocate || fmtcnt < 0 || use_bytearray);
assert(writer.overallocate || fmtcnt == 0 || use_bytearray);
} /* until end */
if (argidx < arglen && !dict) {