mirror of https://github.com/python/cpython
Fix ProcessTestCasePOSIXPurePython to test the module from import when
_posixsubprocess doesn't exist rather than simply stubbing it out after the fact. This adds coverage for the RuntimeWarning as well as using the pure python _create_pipe instead of using _posixsubprocess.cloexec_pipe unintentionally with the pure python code. Ironically: I don't think any platform should ever actually _use_ the pure Python subprocess code on POSIX platforms anymore. This at least tests it properly in this stable branch. The pure python code for this is likely to be removed in 3.3.
This commit is contained in:
parent
e4eed06dfa
commit
c80504fb69
|
@ -1498,15 +1498,23 @@ class ProcessTestCaseNoPoll(ProcessTestCase):
|
|||
@unittest.skipUnless(getattr(subprocess, '_posixsubprocess', False),
|
||||
"_posixsubprocess extension module not found.")
|
||||
class ProcessTestCasePOSIXPurePython(ProcessTestCase, POSIXProcessTestCase):
|
||||
def setUp(self):
|
||||
subprocess._posixsubprocess = None
|
||||
ProcessTestCase.setUp(self)
|
||||
POSIXProcessTestCase.setUp(self)
|
||||
@classmethod
|
||||
def setUpClass(cls):
|
||||
global subprocess
|
||||
assert subprocess._posixsubprocess
|
||||
# Reimport subprocess while forcing _posixsubprocess to not exist.
|
||||
with support.check_warnings(('.*_posixsubprocess .* not being used.*',
|
||||
RuntimeWarning)):
|
||||
subprocess = support.import_fresh_module(
|
||||
'subprocess', blocked=['_posixsubprocess'])
|
||||
assert not subprocess._posixsubprocess
|
||||
|
||||
def tearDown(self):
|
||||
subprocess._posixsubprocess = sys.modules['_posixsubprocess']
|
||||
POSIXProcessTestCase.tearDown(self)
|
||||
ProcessTestCase.tearDown(self)
|
||||
@classmethod
|
||||
def tearDownClass(cls):
|
||||
global subprocess
|
||||
# Reimport subprocess as it should be, restoring order to the universe.
|
||||
subprocess = support.import_fresh_module('subprocess')
|
||||
assert subprocess._posixsubprocess
|
||||
|
||||
|
||||
class HelperFunctionTests(unittest.TestCase):
|
||||
|
|
Loading…
Reference in New Issue