Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

gh-122392: IDLE - Fix overlapping lines in browsers (#122392) (#124975) 

Increase currently inadequate vertical spacing for the IDLE browsers (path,
module, and stack) on high-resolution monitors.
---------

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
This commit is contained in:
Zhikang Yan 2024-10-08 02:52:09 +08:00 committed by GitHub
parent 7ffe94fb24
commit c5df1cb7bd
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
Lib/idlelib/tree.py
View File

@ -83,6 +83,8 @@ def wheel_event(event, widget=None):
class TreeNode: class TreeNode:
dy = 0
def __init__(self, canvas, parent, item): def __init__(self, canvas, parent, item):
self.canvas = canvas self.canvas = canvas
self.parent = parent self.parent = parent
@ -199,23 +201,22 @@ class TreeNode:
def draw(self, x, y): def draw(self, x, y):
# XXX This hard-codes too many geometry constants! # XXX This hard-codes too many geometry constants!
dy = 20
self.x, self.y = x, y self.x, self.y = x, y
self.drawicon() self.drawicon()
self.drawtext() self.drawtext()
if self.state != 'expanded': if self.state != 'expanded':
return y + dy return y + TreeNode.dy
# draw children # draw children
if not self.children: if not self.children:
sublist = self.item._GetSubList() sublist = self.item._GetSubList()
if not sublist: if not sublist:
# _IsExpandable() was mistaken; that's allowed # _IsExpandable() was mistaken; that's allowed
return y+17 return y + TreeNode.dy
for item in sublist: for item in sublist:
child = self.__class__(self.canvas, self, item) child = self.__class__(self.canvas, self, item)
self.children.append(child) self.children.append(child)
cx = x+20 cx = x+20
cy = y + dy cy = y + TreeNode.dy
cylast = 0 cylast = 0
for child in self.children: for child in self.children:
cylast = cy cylast = cy
@ -289,6 +290,11 @@ class TreeNode:
self.label.bind("<Button-4>", lambda e: wheel_event(e, self.canvas)) self.label.bind("<Button-4>", lambda e: wheel_event(e, self.canvas))
self.label.bind("<Button-5>", lambda e: wheel_event(e, self.canvas)) self.label.bind("<Button-5>", lambda e: wheel_event(e, self.canvas))
self.text_id = id self.text_id = id
if TreeNode.dy == 0:
# The first row doesn't matter what the dy is, just measure its
# size to get the value of the subsequent dy
coords = self.canvas.bbox(id)
TreeNode.dy = max(20, coords[3] - coords[1] - 3)
def select_or_edit(self, event=None): def select_or_edit(self, event=None):
if self.selected and self.item.IsEditable(): if self.selected and self.item.IsEditable():

2
Misc/NEWS.d/next/IDLE/2024-10-04-15-34-34.gh-issue-122392.V8K3w2.rst Normal file
View File

@ -0,0 +1,2 @@
Increase currently inadequate vertical spacing for the IDLE browsers (path,
module, and stack) on high-resolution monitors.