Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

use PyBUF_LOCK instead of PyBUF_SIMPLE for bsddb data access as it'll often 

be using the data buffer provided without the GIL held.
This commit is contained in:
Gregory P. Smith 2008-03-17 20:16:47 +00:00
parent 74ca557e1e
commit c55485bc6d
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Modules/_bsddb.c
View File

@ -312,10 +312,9 @@ static Py_buffer * _malloc_view(PyObject *obj)
"Py_buffer malloc failed");
return NULL;
}
/* XXX(gps): PyBUF_LOCKDATA is desired to prevent other theads from
trashing the data buffer while we release the GIL during the db
operation. see http://bugs.python.org/issue1035 */
if (PyObject_GetBuffer(obj, view, PyBUF_SIMPLE) == -1) {
/* We use PyBUF_LOCK to prevent other threads from trashing the data
buffer while we release the GIL. http://bugs.python.org/issue1035 */
if (PyObject_GetBuffer(obj, view, PyBUF_LOCK) == -1) {
PyMem_Free(view);
return NULL;
}