Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

Fix CID-1420310: cast PY_TIMEOUT_MAX to _Py_time_t (#4646) 

Fix the following false-alarm Coverity warning:

    Result is not floating-point
    (UNINTENDED_INTEGER_DIVISION)integer_division: Dividing integer
    expressions 9223372036854775807LL and 1000LL, and then converting
    the integer quotient to type double. Any remainder, or fractional
    part of the quotient, is ignored.

    To compute and use a non-integer quotient, change or cast either
    operand to type double. If integer division is intended, consider
    indicating that by casting the result to type long long .
This commit is contained in:
Victor Stinner 2017-11-30 23:03:47 +01:00 committed by GitHub
parent 3be3b97a97
commit c319eeeb45
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Modules/_threadmodule.c
View File

@ -1363,7 +1363,7 @@ PyInit__thread(void)
if (m == NULL)
return NULL;
timeout_max = (double)PY_TIMEOUT_MAX * 1e-6;
timeout_max = (_PyTime_t)PY_TIMEOUT_MAX * 1e-6;
time_max = _PyTime_AsSecondsDouble(_PyTime_MAX);
timeout_max = Py_MIN(timeout_max, time_max);
/* Round towards minus infinity */