mirror of https://github.com/python/cpython
Accept None as start and stop parameters for list.index() and tuple.index()
Closes #13340.
This commit is contained in:
parent
4e6bf41934
commit
c2f0a46111
|
@ -365,6 +365,13 @@ class CommonTest(seq_tests.CommonTest):
|
||||||
self.assertEqual(u.index(0, 3), 3)
|
self.assertEqual(u.index(0, 3), 3)
|
||||||
self.assertEqual(u.index(0, 3, 4), 3)
|
self.assertEqual(u.index(0, 3, 4), 3)
|
||||||
self.assertRaises(ValueError, u.index, 2, 0, -10)
|
self.assertRaises(ValueError, u.index, 2, 0, -10)
|
||||||
|
self.assertEqual(u.index(1, None), 4)
|
||||||
|
self.assertEqual(u.index(1, None, None), 4)
|
||||||
|
self.assertEqual(u.index(1, 0, None), 4)
|
||||||
|
self.assertEqual(u.index(1, None, 6), 4)
|
||||||
|
self.assertRaises(ValueError, u.index, -1, 3)
|
||||||
|
self.assertRaises(ValueError, u.index, -1, 3, None)
|
||||||
|
self.assertRaises(ValueError, u.index, 1, None, 4)
|
||||||
|
|
||||||
self.assertRaises(TypeError, u.index)
|
self.assertRaises(TypeError, u.index)
|
||||||
|
|
||||||
|
|
|
@ -361,6 +361,13 @@ class CommonTest(unittest.TestCase):
|
||||||
self.assertEqual(u.index(0, 3), 3)
|
self.assertEqual(u.index(0, 3), 3)
|
||||||
self.assertEqual(u.index(0, 3, 4), 3)
|
self.assertEqual(u.index(0, 3, 4), 3)
|
||||||
self.assertRaises(ValueError, u.index, 2, 0, -10)
|
self.assertRaises(ValueError, u.index, 2, 0, -10)
|
||||||
|
self.assertEqual(u.index(1, None), 4)
|
||||||
|
self.assertEqual(u.index(1, None, None), 4)
|
||||||
|
self.assertEqual(u.index(1, 0, None), 4)
|
||||||
|
self.assertEqual(u.index(1, None, 6), 4)
|
||||||
|
self.assertRaises(ValueError, u.index, -1, 3)
|
||||||
|
self.assertRaises(ValueError, u.index, -1, 3, None)
|
||||||
|
self.assertRaises(ValueError, u.index, 1, None, 4)
|
||||||
|
|
||||||
self.assertRaises(TypeError, u.index)
|
self.assertRaises(TypeError, u.index)
|
||||||
|
|
||||||
|
|
|
@ -10,6 +10,9 @@ What's New in Python 3.2.3?
|
||||||
Core and Builtins
|
Core and Builtins
|
||||||
-----------------
|
-----------------
|
||||||
|
|
||||||
|
- Issue #13340: Accept None as start and stop parameters for
|
||||||
|
list.index() and tuple.index().
|
||||||
|
|
||||||
- Issue #13343: Fix a SystemError when a lambda expression uses a global
|
- Issue #13343: Fix a SystemError when a lambda expression uses a global
|
||||||
variable in the default value of a keyword-only argument:
|
variable in the default value of a keyword-only argument:
|
||||||
(lambda *, arg=GLOBAL_NAME: None)
|
(lambda *, arg=GLOBAL_NAME: None)
|
||||||
|
|
|
@ -2109,12 +2109,20 @@ listindex(PyListObject *self, PyObject *args)
|
||||||
{
|
{
|
||||||
Py_ssize_t i, start=0, stop=Py_SIZE(self);
|
Py_ssize_t i, start=0, stop=Py_SIZE(self);
|
||||||
PyObject *v, *format_tuple, *err_string;
|
PyObject *v, *format_tuple, *err_string;
|
||||||
|
PyObject *start_obj = NULL, *stop_obj = NULL;
|
||||||
static PyObject *err_format = NULL;
|
static PyObject *err_format = NULL;
|
||||||
|
|
||||||
if (!PyArg_ParseTuple(args, "O|O&O&:index", &v,
|
if (!PyArg_ParseTuple(args, "O|OO:index", &v, &start_obj, &stop_obj))
|
||||||
_PyEval_SliceIndex, &start,
|
|
||||||
_PyEval_SliceIndex, &stop))
|
|
||||||
return NULL;
|
return NULL;
|
||||||
|
|
||||||
|
if (start_obj != Py_None)
|
||||||
|
if (!_PyEval_SliceIndex(start_obj, &start))
|
||||||
|
return NULL;
|
||||||
|
|
||||||
|
if (stop_obj != Py_None)
|
||||||
|
if (!_PyEval_SliceIndex(stop_obj, &stop))
|
||||||
|
return NULL;
|
||||||
|
|
||||||
if (start < 0) {
|
if (start < 0) {
|
||||||
start += Py_SIZE(self);
|
start += Py_SIZE(self);
|
||||||
if (start < 0)
|
if (start < 0)
|
||||||
|
|
|
@ -483,12 +483,19 @@ static PyObject *
|
||||||
tupleindex(PyTupleObject *self, PyObject *args)
|
tupleindex(PyTupleObject *self, PyObject *args)
|
||||||
{
|
{
|
||||||
Py_ssize_t i, start=0, stop=Py_SIZE(self);
|
Py_ssize_t i, start=0, stop=Py_SIZE(self);
|
||||||
PyObject *v;
|
PyObject *v, *start_obj = NULL, *stop_obj = NULL;
|
||||||
|
|
||||||
if (!PyArg_ParseTuple(args, "O|O&O&:index", &v,
|
if (!PyArg_ParseTuple(args, "O|OO:index", &v, &start_obj, &stop_obj))
|
||||||
_PyEval_SliceIndex, &start,
|
|
||||||
_PyEval_SliceIndex, &stop))
|
|
||||||
return NULL;
|
return NULL;
|
||||||
|
|
||||||
|
if (start_obj != Py_None)
|
||||||
|
if (!_PyEval_SliceIndex(start_obj, &start))
|
||||||
|
return NULL;
|
||||||
|
|
||||||
|
if (stop_obj != Py_None)
|
||||||
|
if (!_PyEval_SliceIndex(stop_obj, &stop))
|
||||||
|
return NULL;
|
||||||
|
|
||||||
if (start < 0) {
|
if (start < 0) {
|
||||||
start += Py_SIZE(self);
|
start += Py_SIZE(self);
|
||||||
if (start < 0)
|
if (start < 0)
|
||||||
|
|
Loading…
Reference in New Issue