gh-124502: Optimize unicode_eq() (#125105)

This commit is contained in:
Victor Stinner 2024-10-08 16:25:24 +02:00 committed by GitHub
parent e99f159be4
commit c203955f3b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 12 additions and 7 deletions

View File

@ -4,14 +4,19 @@
* unicode_eq() is called when the hash of two unicode objects is equal. * unicode_eq() is called when the hash of two unicode objects is equal.
*/ */
Py_LOCAL_INLINE(int) Py_LOCAL_INLINE(int)
unicode_eq(PyObject *a, PyObject *b) unicode_eq(PyObject *str1, PyObject *str2)
{ {
if (PyUnicode_GET_LENGTH(a) != PyUnicode_GET_LENGTH(b)) Py_ssize_t len = PyUnicode_GET_LENGTH(str1);
if (PyUnicode_GET_LENGTH(str2) != len) {
return 0; return 0;
if (PyUnicode_GET_LENGTH(a) == 0) }
return 1;
if (PyUnicode_KIND(a) != PyUnicode_KIND(b)) int kind = PyUnicode_KIND(str1);
return 0; if (PyUnicode_KIND(str2) != kind) {
return memcmp(PyUnicode_1BYTE_DATA(a), PyUnicode_1BYTE_DATA(b), return 0;
PyUnicode_GET_LENGTH(a) * PyUnicode_KIND(a)) == 0; }
const void *data1 = PyUnicode_DATA(str1);
const void *data2 = PyUnicode_DATA(str2);
return (memcmp(data1, data2, len * kind) == 0);
} }