Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

Add another try/except PermissionError to avoid depending on listdir order. Fix issues #24120 and #26012.

This commit is contained in:
Guido van Rossum 2016-01-07 10:56:36 -08:00
parent f3695bfacf
commit bc9fddaf50
2 changed files with 16 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Lib/pathlib.py
View File

@ -494,11 +494,14 @@ class _RecursiveWildcardSelector(_Selector):
def _iterate_directories(self, parent_path, is_dir, listdir): def _iterate_directories(self, parent_path, is_dir, listdir):
yield parent_path yield parent_path
for name in listdir(parent_path): try:
path = parent_path._make_child_relpath(name) for name in listdir(parent_path):
if is_dir(path) and not path.is_symlink(): path = parent_path._make_child_relpath(name)
for p in self._iterate_directories(path, is_dir, listdir): if is_dir(path) and not path.is_symlink():
yield p for p in self._iterate_directories(path, is_dir, listdir):
yield p
except PermissionError:
return
def _select_from(self, parent_path, is_dir, exists, listdir): def _select_from(self, parent_path, is_dir, exists, listdir):
try: try:

16
Lib/test/test_pathlib.py
View File

@ -1240,7 +1240,7 @@ class _BasePathTest(object):
# | |-- dirD # | |-- dirD
# | | `-- fileD # | | `-- fileD
# | `-- fileC # | `-- fileC
# |-- dirE # |-- dirE # No permissions
# |-- fileA # |-- fileA
# |-- linkA -> fileA # |-- linkA -> fileA
# `-- linkB -> dirB # `-- linkB -> dirB
@ -1396,13 +1396,13 @@ class _BasePathTest(object):
p = P(BASE) p = P(BASE)
it = p.rglob("fileA") it = p.rglob("fileA")
self.assertIsInstance(it, collections.Iterator) self.assertIsInstance(it, collections.Iterator)
# XXX cannot test because of symlink loops in the test setup _check(it, ["fileA"])
#_check(it, ["fileA"]) _check(p.rglob("fileB"), ["dirB/fileB"])
#_check(p.rglob("fileB"), ["dirB/fileB"]) _check(p.rglob("*/fileA"), [])
#_check(p.rglob("*/fileA"), [""]) _check(p.rglob("*/fileB"), ["dirB/fileB", "dirB/linkD/fileB",
#_check(p.rglob("*/fileB"), ["dirB/fileB"]) "linkB/fileB", "dirA/linkC/fileB"])
#_check(p.rglob("file*"), ["fileA", "dirB/fileB"]) _check(p.rglob("file*"), ["fileA", "dirB/fileB",
# No symlink loops here "dirC/fileC", "dirC/dirD/fileD"])
p = P(BASE, "dirC") p = P(BASE, "dirC")
_check(p.rglob("file*"), ["dirC/fileC", "dirC/dirD/fileD"]) _check(p.rglob("file*"), ["dirC/fileC", "dirC/dirD/fileD"])
_check(p.rglob("*/*"), ["dirC/dirD/fileD"]) _check(p.rglob("*/*"), ["dirC/dirD/fileD"])