From ba21f618a301a36b13a25c2d51e74562363c6d67 Mon Sep 17 00:00:00 2001 From: Collin Winter Date: Sat, 1 Sep 2007 20:29:04 +0000 Subject: [PATCH] Fix refleaks in test_with caused by reusing the same exception instance over and over. --- Lib/test/test_with.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Lib/test/test_with.py b/Lib/test/test_with.py index 4fc8fe9fca5..a7bc2068b4c 100644 --- a/Lib/test/test_with.py +++ b/Lib/test/test_with.py @@ -187,7 +187,9 @@ class FailureTestCase(unittest.TestCase): self.assertRaises(RuntimeError, shouldThrow) class ContextmanagerAssertionMixin(object): - TEST_EXCEPTION = RuntimeError("test exception") + + def setUp(self): + self.TEST_EXCEPTION = RuntimeError("test exception") def assertInWithManagerInvariants(self, mock_manager): self.assertTrue(mock_manager.enter_called) @@ -353,7 +355,7 @@ class NestedNonexceptionalTestCase(unittest.TestCase, self.assertAfterWithManagerInvariantsNoError(mock_nested) -class ExceptionalTestCase(unittest.TestCase, ContextmanagerAssertionMixin): +class ExceptionalTestCase(ContextmanagerAssertionMixin, unittest.TestCase): def testSingleResource(self): cm = mock_contextmanager_generator() def shouldThrow():