Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

gh-100519: simplification to `eff_request_host` in cookiejar.py (#99588) 

`IPV4_RE` includes a `.`, and the `.find(".") == -1` included here is already testing to make sure there's no dot, so this part of the expression is tautological. Instead use more modern `in` syntax to make it clear what the check is doing here. The simplified implementation more clearly matches the wording in RFC 2965.

Co-authored-by: hauntsaninja <hauntsaninja@gmail.com>
This commit is contained in:
Glyph 2022-12-24 16:14:51 -08:00 committed by GitHub
parent 046cbc2080
commit b9aa14a484
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Lib/http/cookiejar.py
View File

@ -640,7 +640,7 @@ def eff_request_host(request):
"""
erhn = req_host = request_host(request)
if req_host.find(".") == -1 and not IPV4_RE.search(req_host):
if "." not in req_host:
erhn = req_host + ".local"
return req_host, erhn

2
Misc/NEWS.d/next/Library/2022-12-24-16-39-53.gh-issue-100519.G_dZLP.rst Normal file
View File

@ -0,0 +1,2 @@
Small simplification of :func:`http.cookiejar.eff_request_host` that
improves readability and better matches the RFC wording.