Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

bpo-46333: include `module` in `ForwardRef.__repr__` (#31283) 

The module parameter carries semantic information about the forward ref.
Show to the user that forward refs with same argument but different
module are different.

Co-authored-by: Andreas Hangauer <andreas.hangauer@siemens.com>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
This commit is contained in:
aha79 2022-02-12 16:35:57 +01:00 committed by GitHub
parent 8aaaf7e182
commit b70690bb37
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Lib/test/test_typing.py
View File

@ -2862,6 +2862,8 @@ class ForwardRefTests(BaseTestCase):
def test_forward_repr(self):
self.assertEqual(repr(List['int']), "typing.List[ForwardRef('int')]")
self.assertEqual(repr(List[ForwardRef('int', module='mod')]),
"typing.List[ForwardRef('int', module='mod')]")
def test_union_forward(self):

6
Lib/typing.py
View File

@ -779,7 +779,11 @@ class ForwardRef(_Final, _root=True):
return Union[other, self]
def __repr__(self):
return f'ForwardRef({self.__forward_arg__!r})'
if self.__forward_module__ is None:
module_repr = ''
else:
module_repr = f', module={self.__forward_module__!r}'
return f'ForwardRef({self.__forward_arg__!r}{module_repr})'
class _TypeVarLike:
"""Mixin for TypeVar-like types (TypeVar and ParamSpec)."""

3
Misc/NEWS.d/next/Library/2022-02-11-20-01-49.bpo-46333.PMTBY9.rst Normal file
View File

@ -0,0 +1,3 @@
The :meth:`__repr__` method of :class:`typing.ForwardRef` now
includes the ``module`` parameter of :class:`typing.ForwardRef`
when it is set.