mirror of https://github.com/python/cpython
bpo-42627: Fix incorrect parsing of Windows registry proxy settings (GH-26307)
This commit is contained in:
parent
ffcc7cd57f
commit
b69297ea23
|
@ -2679,22 +2679,26 @@ elif os.name == 'nt':
|
|||
# Returned as Unicode but problems if not converted to ASCII
|
||||
proxyServer = str(winreg.QueryValueEx(internetSettings,
|
||||
'ProxyServer')[0])
|
||||
if '=' in proxyServer:
|
||||
# Per-protocol settings
|
||||
for p in proxyServer.split(';'):
|
||||
protocol, address = p.split('=', 1)
|
||||
# See if address has a type:// prefix
|
||||
if not re.match('(?:[^/:]+)://', address):
|
||||
address = '%s://%s' % (protocol, address)
|
||||
proxies[protocol] = address
|
||||
else:
|
||||
# Use one setting for all protocols
|
||||
if proxyServer[:5] == 'http:':
|
||||
proxies['http'] = proxyServer
|
||||
else:
|
||||
proxies['http'] = 'http://%s' % proxyServer
|
||||
proxies['https'] = 'https://%s' % proxyServer
|
||||
proxies['ftp'] = 'ftp://%s' % proxyServer
|
||||
if '=' not in proxyServer and ';' not in proxyServer:
|
||||
# Use one setting for all protocols.
|
||||
proxyServer = 'http={0};https={0};ftp={0}'.format(proxyServer)
|
||||
for p in proxyServer.split(';'):
|
||||
protocol, address = p.split('=', 1)
|
||||
# See if address has a type:// prefix
|
||||
if not re.match('(?:[^/:]+)://', address):
|
||||
# Add type:// prefix to address without specifying type
|
||||
if protocol in ('http', 'https', 'ftp'):
|
||||
# The default proxy type of Windows is HTTP
|
||||
address = 'http://' + address
|
||||
elif protocol == 'socks':
|
||||
address = 'socks://' + address
|
||||
proxies[protocol] = address
|
||||
# Use SOCKS proxy for HTTP(S) protocols
|
||||
if proxies.get('socks'):
|
||||
# The default SOCKS proxy type of Windows is SOCKS4
|
||||
address = re.sub(r'^socks://', 'socks4://', proxies['socks'])
|
||||
proxies['http'] = proxies.get('http') or address
|
||||
proxies['https'] = proxies.get('https') or address
|
||||
internetSettings.Close()
|
||||
except (OSError, ValueError, TypeError):
|
||||
# Either registry key not found etc, or the value in an
|
||||
|
|
|
@ -0,0 +1 @@
|
|||
Fix incorrect parsing of Windows registry proxy settings
|
Loading…
Reference in New Issue