From b4dc6af7a7862a8996cffed30d39d6add5ee58a3 Mon Sep 17 00:00:00 2001 From: Dong-hee Na Date: Thu, 20 Apr 2017 16:31:17 +0900 Subject: [PATCH] bpo-12414: Update code_sizeof() to take in account co_extra memory. (#1168) --- Lib/test/test_sys.py | 8 +++++--- Misc/ACKS | 1 + Misc/NEWS | 4 ++++ Objects/codeobject.c | 8 ++++++-- 4 files changed, 16 insertions(+), 5 deletions(-) diff --git a/Lib/test/test_sys.py b/Lib/test/test_sys.py index 748445eb5b6..ed78e2a0f9a 100644 --- a/Lib/test/test_sys.py +++ b/Lib/test/test_sys.py @@ -922,13 +922,15 @@ class SizeofTest(unittest.TestCase): return inner check(get_cell().__closure__[0], size('P')) # code - check(get_cell().__code__, size('6i13P')) - check(get_cell.__code__, size('6i13P')) + def check_code_size(a, expected_size): + self.assertGreaterEqual(sys.getsizeof(a), expected_size) + check_code_size(get_cell().__code__, size('6i13P')) + check_code_size(get_cell.__code__, size('6i13P')) def get_cell2(x): def inner(): return x return inner - check(get_cell2.__code__, size('6i13P') + calcsize('n')) + check_code_size(get_cell2.__code__, size('6i13P') + calcsize('n')) # complex check(complex(0,1), size('2d')) # method_descriptor (descriptor object) diff --git a/Misc/ACKS b/Misc/ACKS index 8c4439721ea..d4f20c548f6 100644 --- a/Misc/ACKS +++ b/Misc/ACKS @@ -1063,6 +1063,7 @@ R. David Murray Matti Mäki Jörg Müller Kaushik N +Dong-hee Na Dale Nagata John Nagle Takahiro Nakayama diff --git a/Misc/NEWS b/Misc/NEWS index 3ec02e0e3e8..7e09eff4e0a 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -10,6 +10,10 @@ What's New in Python 3.7.0 alpha 1? Core and Builtins ----------------- +- bpo-12414: sys.getsizeof() on a code object now returns the sizes + which includes the code struct and sizes of objects which it references. + Patch by Dong-hee Na. + - bpo-29839: len() now raises ValueError rather than OverflowError if __len__() returned a large negative integer. diff --git a/Objects/codeobject.c b/Objects/codeobject.c index ebc70669fec..46bc45d5ac1 100644 --- a/Objects/codeobject.c +++ b/Objects/codeobject.c @@ -451,11 +451,15 @@ code_dealloc(PyCodeObject *co) static PyObject * code_sizeof(PyCodeObject *co, void *unused) { - Py_ssize_t res; + Py_ssize_t res = _PyObject_SIZE(Py_TYPE(co)); + _PyCodeObjectExtra *co_extra = (_PyCodeObjectExtra*) co->co_extra; - res = _PyObject_SIZE(Py_TYPE(co)); if (co->co_cell2arg != NULL && co->co_cellvars != NULL) res += PyTuple_GET_SIZE(co->co_cellvars) * sizeof(Py_ssize_t); + + if (co_extra != NULL) + res += co_extra->ce_size * sizeof(co_extra->ce_extras[0]); + return PyLong_FromSsize_t(res); }