Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

[gh-117657] _Py_MergeZeroLocalRefcount isn't loading ob_ref_shared with strong enough semantics (#118111) 

Use acquire for load of ob_ref_shared
This commit is contained in:
Dino Viehland 2024-04-19 14:21:01 -07:00 committed by GitHub
parent b624490dee
commit b45af00bad
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Objects/object.c
View File

@ -374,7 +374,7 @@ _Py_MergeZeroLocalRefcount(PyObject *op)
assert(op->ob_ref_local == 0); assert(op->ob_ref_local == 0);
_Py_atomic_store_uintptr_relaxed(&op->ob_tid, 0); _Py_atomic_store_uintptr_relaxed(&op->ob_tid, 0);
Py_ssize_t shared = _Py_atomic_load_ssize_relaxed(&op->ob_ref_shared); Py_ssize_t shared = _Py_atomic_load_ssize_acquire(&op->ob_ref_shared);
if (shared == 0) { if (shared == 0) {
// Fast-path: shared refcount is zero (including flags) // Fast-path: shared refcount is zero (including flags)
_Py_Dealloc(op); _Py_Dealloc(op);