mirror of https://github.com/python/cpython
Issue #20766: Merge with 3.6.
This commit is contained in:
commit
b4474848de
10
Lib/pdb.py
10
Lib/pdb.py
|
@ -135,6 +135,8 @@ line_prefix = '\n-> ' # Probably a better default
|
||||||
|
|
||||||
class Pdb(bdb.Bdb, cmd.Cmd):
|
class Pdb(bdb.Bdb, cmd.Cmd):
|
||||||
|
|
||||||
|
_previous_sigint_handler = None
|
||||||
|
|
||||||
def __init__(self, completekey='tab', stdin=None, stdout=None, skip=None,
|
def __init__(self, completekey='tab', stdin=None, stdout=None, skip=None,
|
||||||
nosigint=False, readrc=True):
|
nosigint=False, readrc=True):
|
||||||
bdb.Bdb.__init__(self, skip=skip)
|
bdb.Bdb.__init__(self, skip=skip)
|
||||||
|
@ -189,8 +191,6 @@ class Pdb(bdb.Bdb, cmd.Cmd):
|
||||||
self.message("\nProgram interrupted. (Use 'cont' to resume).")
|
self.message("\nProgram interrupted. (Use 'cont' to resume).")
|
||||||
self.set_step()
|
self.set_step()
|
||||||
self.set_trace(frame)
|
self.set_trace(frame)
|
||||||
# restore previous signal handler
|
|
||||||
signal.signal(signal.SIGINT, self._previous_sigint_handler)
|
|
||||||
|
|
||||||
def reset(self):
|
def reset(self):
|
||||||
bdb.Bdb.reset(self)
|
bdb.Bdb.reset(self)
|
||||||
|
@ -339,6 +339,10 @@ class Pdb(bdb.Bdb, cmd.Cmd):
|
||||||
(expr, newvalue, oldvalue))
|
(expr, newvalue, oldvalue))
|
||||||
|
|
||||||
def interaction(self, frame, traceback):
|
def interaction(self, frame, traceback):
|
||||||
|
# Restore the previous signal handler at the Pdb prompt.
|
||||||
|
if Pdb._previous_sigint_handler:
|
||||||
|
signal.signal(signal.SIGINT, Pdb._previous_sigint_handler)
|
||||||
|
Pdb._previous_sigint_handler = None
|
||||||
if self.setup(frame, traceback):
|
if self.setup(frame, traceback):
|
||||||
# no interaction desired at this time (happens if .pdbrc contains
|
# no interaction desired at this time (happens if .pdbrc contains
|
||||||
# a command like "continue")
|
# a command like "continue")
|
||||||
|
@ -1039,7 +1043,7 @@ class Pdb(bdb.Bdb, cmd.Cmd):
|
||||||
"""
|
"""
|
||||||
if not self.nosigint:
|
if not self.nosigint:
|
||||||
try:
|
try:
|
||||||
self._previous_sigint_handler = \
|
Pdb._previous_sigint_handler = \
|
||||||
signal.signal(signal.SIGINT, self.sigint_handler)
|
signal.signal(signal.SIGINT, self.sigint_handler)
|
||||||
except ValueError:
|
except ValueError:
|
||||||
# ValueError happens when do_continue() is invoked from
|
# ValueError happens when do_continue() is invoked from
|
||||||
|
|
|
@ -911,6 +911,29 @@ def test_pdb_next_command_subiterator():
|
||||||
(Pdb) continue
|
(Pdb) continue
|
||||||
"""
|
"""
|
||||||
|
|
||||||
|
def test_pdb_issue_20766():
|
||||||
|
"""Test for reference leaks when the SIGINT handler is set.
|
||||||
|
|
||||||
|
>>> def test_function():
|
||||||
|
... i = 1
|
||||||
|
... while i <= 2:
|
||||||
|
... sess = pdb.Pdb()
|
||||||
|
... sess.set_trace(sys._getframe())
|
||||||
|
... print('pdb %d: %s' % (i, sess._previous_sigint_handler))
|
||||||
|
... i += 1
|
||||||
|
|
||||||
|
>>> with PdbTestInput(['continue',
|
||||||
|
... 'continue']):
|
||||||
|
... test_function()
|
||||||
|
> <doctest test.test_pdb.test_pdb_issue_20766[0]>(6)test_function()
|
||||||
|
-> print('pdb %d: %s' % (i, sess._previous_sigint_handler))
|
||||||
|
(Pdb) continue
|
||||||
|
pdb 1: <built-in function default_int_handler>
|
||||||
|
> <doctest test.test_pdb.test_pdb_issue_20766[0]>(5)test_function()
|
||||||
|
-> sess.set_trace(sys._getframe())
|
||||||
|
(Pdb) continue
|
||||||
|
pdb 2: <built-in function default_int_handler>
|
||||||
|
"""
|
||||||
|
|
||||||
class PdbTestCase(unittest.TestCase):
|
class PdbTestCase(unittest.TestCase):
|
||||||
|
|
||||||
|
|
|
@ -85,6 +85,9 @@ Core and Builtins
|
||||||
Library
|
Library
|
||||||
-------
|
-------
|
||||||
|
|
||||||
|
- Issue #20766: Fix references leaked by pdb in the handling of SIGINT
|
||||||
|
handlers.
|
||||||
|
|
||||||
- Issue #27998: Fixed bytes path support in os.scandir() on Windows.
|
- Issue #27998: Fixed bytes path support in os.scandir() on Windows.
|
||||||
Patch by Eryk Sun.
|
Patch by Eryk Sun.
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue