Micro optimization. In the first case, we know that frame->f_exc_type

is NULL, so there's no reason to do anything with it.  In the second case,
we know frame->f_exc_type is not NULL, so we can just do an INCREF.
This commit is contained in:
Neal Norwitz 2006-05-09 05:38:56 +00:00
parent e854e765f4
commit b255069d43
1 changed files with 1 additions and 3 deletions

View File

@ -2899,7 +2899,6 @@ set_exc_info(PyThreadState *tstate,
Py_INCREF(Py_None); Py_INCREF(Py_None);
tstate->exc_type = Py_None; tstate->exc_type = Py_None;
} }
tmp_type = frame->f_exc_type;
tmp_value = frame->f_exc_value; tmp_value = frame->f_exc_value;
tmp_tb = frame->f_exc_traceback; tmp_tb = frame->f_exc_traceback;
Py_XINCREF(tstate->exc_type); Py_XINCREF(tstate->exc_type);
@ -2908,7 +2907,6 @@ set_exc_info(PyThreadState *tstate,
frame->f_exc_type = tstate->exc_type; frame->f_exc_type = tstate->exc_type;
frame->f_exc_value = tstate->exc_value; frame->f_exc_value = tstate->exc_value;
frame->f_exc_traceback = tstate->exc_traceback; frame->f_exc_traceback = tstate->exc_traceback;
Py_XDECREF(tmp_type);
Py_XDECREF(tmp_value); Py_XDECREF(tmp_value);
Py_XDECREF(tmp_tb); Py_XDECREF(tmp_tb);
} }
@ -2942,7 +2940,7 @@ reset_exc_info(PyThreadState *tstate)
tmp_type = tstate->exc_type; tmp_type = tstate->exc_type;
tmp_value = tstate->exc_value; tmp_value = tstate->exc_value;
tmp_tb = tstate->exc_traceback; tmp_tb = tstate->exc_traceback;
Py_XINCREF(frame->f_exc_type); Py_INCREF(frame->f_exc_type);
Py_XINCREF(frame->f_exc_value); Py_XINCREF(frame->f_exc_value);
Py_XINCREF(frame->f_exc_traceback); Py_XINCREF(frame->f_exc_traceback);
tstate->exc_type = frame->f_exc_type; tstate->exc_type = frame->f_exc_type;