Issue #11714: Use 'with' statements to assure a Semaphore releases a

condition variable.  Original patch by Thomas Rachel.

Lib/threading.py

@@ -253,31 +253,29 @@ class Semaphore:
             raise ValueError("can't specify timeout for non-blocking acquire")
         rc = False
         endtime = None
-        self._cond.acquire()
+        with self._cond:
-        while self._value == 0:
+            while self._value == 0:
-            if not blocking:
+                if not blocking:
-                break
+                    break
-            if timeout is not None:
+                if timeout is not None:
-                if endtime is None:
+                    if endtime is None:
-                    endtime = _time() + timeout
+                        endtime = _time() + timeout
-                else:
+                    else:
-                    timeout = endtime - _time()
+                        timeout = endtime - _time()
-                    if timeout <= 0:
+                        if timeout <= 0:
-                        break
+                            break
-            self._cond.wait(timeout)
+                self._cond.wait(timeout)
-        else:
+            else:
-            self._value -= 1
+                self._value -= 1
-            rc = True
+                rc = True
-        self._cond.release()
         return rc
 
     __enter__ = acquire
 
     def release(self):
-        self._cond.acquire()
+        with self._cond:
-        self._value += 1
+            self._value += 1
-        self._cond.notify()
+            self._cond.notify()
-        self._cond.release()
 
     def __exit__(self, t, v, tb):
         self.release()

Misc/ACKS

@@ -993,6 +993,7 @@ Fernando Pérez
 Pierre Quentel
 Brian Quinlan
 Anders Qvist
+Thomas Rachel
 Ram Rachum
 Jérôme Radix
 Burton Radons

Misc/NEWS

@@ -49,6 +49,9 @@ Core and Builtins
 Library
 -------
 
+- Issue #11714: Use 'with' statements to assure a Semaphore releases a
+  condition variable.  Original patch by Thomas Rachel.
+
 - Issue #16624: `subprocess.check_output` now accepts an `input` argument,
   allowing the subprocess's stdin to be provided as a (byte) string.
   Patch by Zack Weinberg.