Issue #18189: add test_delegator for Idle Delegator class.

Also change private dict used as a set to a set.
This commit is contained in:
Terry Jan Reedy 2013-06-30 18:37:05 -04:00
parent ef1f777e0a
commit acd5f81149
2 changed files with 39 additions and 2 deletions

View File

@ -4,12 +4,12 @@ class Delegator:
def __init__(self, delegate=None): def __init__(self, delegate=None):
self.delegate = delegate self.delegate = delegate
self.__cache = {} self.__cache = set()
def __getattr__(self, name): def __getattr__(self, name):
attr = getattr(self.delegate, name) # May raise AttributeError attr = getattr(self.delegate, name) # May raise AttributeError
setattr(self, name, attr) setattr(self, name, attr)
self.__cache[name] = attr self.__cache.add(name)
return attr return attr
def resetcache(self): def resetcache(self):

View File

@ -0,0 +1,37 @@
import unittest
from idlelib.Delegator import Delegator
class DelegatorTest(unittest.TestCase):
def test_mydel(self):
# test a simple use scenario
# initialize
mydel = Delegator(int)
self.assertIs(mydel.delegate, int)
self.assertEqual(mydel._Delegator__cache, set())
# add an attribute:
self.assertRaises(AttributeError, mydel.__getattr__, 'xyz')
bl = mydel.bit_length
self.assertIs(bl, int.bit_length)
self.assertIs(mydel.__dict__['bit_length'], int.bit_length)
self.assertEqual(mydel._Delegator__cache, {'bit_length'})
# add a second attribute
mydel.numerator
self.assertEqual(mydel._Delegator__cache, {'bit_length', 'numerator'})
# delete the second (which, however, leaves it in the name cache)
del mydel.numerator
self.assertNotIn('numerator', mydel.__dict__)
self.assertIn('numerator', mydel._Delegator__cache)
# reset by calling .setdelegate, which calls .resetcache
mydel.setdelegate(float)
self.assertIs(mydel.delegate, float)
self.assertNotIn('bit_length', mydel.__dict__)
self.assertEqual(mydel._Delegator__cache, set())
if __name__ == '__main__':
unittest.main(verbosity=2, exit=2)