Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

Merged revisions 75111 via svnmerge from 

svn+ssh://pythondev@svn.python.org/python/trunk

........
  r75111 | r.david.murray | 2009-09-28 12:57:45 -0400 (Mon, 28 Sep 2009) | 5 lines

  Prevent test_bad_address failure when a domain in the dns search
  path implements a '*' default rule.  Also update comment with
  a more complete explanation of the difficulties inherent in
  the test.
........
This commit is contained in:
R. David Murray 2009-09-28 19:53:25 +00:00
parent e4829f1d77
commit a89633c4f7
1 changed files with 18 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
Lib/test/test_urllib2_localnet.py
View File

@ -467,14 +467,24 @@ class TestUrlopen(unittest.TestCase):
# Make sure proper exception is raised when connecting to a bogus # Make sure proper exception is raised when connecting to a bogus
# address. # address.
self.assertRaises(IOError, self.assertRaises(IOError,
# SF patch 809915: In Sep 2003, VeriSign started # Given that both VeriSign and various ISPs have in
# highjacking invalid .com and .net addresses to # the past or are presently hijacking various invalid
# boost traffic to their own site. This test # domain name requests in an attempt to boost traffic
# started failing then. One hopes the .invalid # to their own sites, finding a domain name to use
# domain will be spared to serve its defined # for this test is difficult. RFC2606 leads one to
# purpose. # believe that '.invalid' should work, but experience
# urllib2.urlopen, "http://www.sadflkjsasadf.com/") # seemed to indicate otherwise. Single character
urllib2.urlopen, "http://sadflkjsasf.i.nvali.d/") # TLDs are likely to remain invalid, so this seems to
# be the best choice. The trailing '.' prevents a
# related problem: The normal DNS resolver appends
# the domain names from the search path if there is
# no '.' the end and, and if one of those domains
# implements a '*' rule a result is returned.
# However, none of this will prevent the test from
# failing if the ISP hijacks all invalid domain
# requests. The real solution would be to be able to
# parameterize the framework with a mock resolver.
urllib2.urlopen, "http://sadflkjsasf.i.nvali.d./")
def test_main(): def test_main():