Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

bpo-31676: Fix test_imp.test_load_source() side effect (#3871) 

test_load_source() now replaces the current __name__ module with a
temporary module to prevent side effects.
This commit is contained in:
Victor Stinner 2017-10-13 13:47:49 -07:00 committed by GitHub
parent a99121526a
commit a505ecdc50
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
Lib/test/test_imp.py
View File

@ -310,8 +310,13 @@ class ImportTests(unittest.TestCase):
loader.get_data(imp.__file__) # Will need to create a newly opened file
def test_load_source(self):
with self.assertRaisesRegex(ValueError, 'embedded null'):
imp.load_source(__name__, __file__ + "\0")
# Create a temporary module since load_source(name) modifies
# sys.modules[name] attributes like __loader___
modname = f"tmp{__name__}"
mod = type(sys.modules[__name__])(modname)
with support.swap_item(sys.modules, modname, mod):
with self.assertRaisesRegex(ValueError, 'embedded null'):
imp.load_source(modname, __file__ + "\0")
@support.cpython_only
def test_issue31315(self):