gh-105866: fix dataclass with slots=True, weakref_slot=True (#105870)

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
Co-authored-by: Carl Meyer <carl@oddbird.net>
This commit is contained in:
Aviel Boag 2024-03-19 02:53:14 +02:00 committed by GitHub
parent 1d82a41235
commit a22d05f04c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 15 additions and 1 deletions

View File

@ -1159,8 +1159,10 @@ def _dataclass_setstate(self, state):
def _get_slots(cls):
match cls.__dict__.get('__slots__'):
# A class which does not define __slots__ at all is equivalent
# to a class defining __slots__ = ('__dict__', '__weakref__')
case None:
return
yield from ('__dict__', '__weakref__')
case str(slot):
yield slot
# Slots may be any iterable, but we cannot handle an iterator

View File

@ -3498,6 +3498,17 @@ class TestSlots(unittest.TestCase):
self.assertIs(a.__weakref__, a_ref)
def test_dataclass_derived_weakref_slot(self):
class A:
pass
@dataclass(slots=True, weakref_slot=True)
class B(A):
pass
B()
class TestDescriptors(unittest.TestCase):
def test_set_name(self):
# See bpo-33141.

View File

@ -0,0 +1 @@
Fixed ``_get_slots`` bug which caused error when defining dataclasses with slots and a weakref_slot.