mirror of https://github.com/python/cpython
Fix misuse of PyUnicode_GET_SIZE() => PyUnicode_GET_LENGTH()
And PyUnicode_GetSize() => PyUnicode_GetLength()
This commit is contained in:
parent
f3ae6208c7
commit
9e30aa52fd
|
@ -207,7 +207,7 @@ _set_char(const char *name, Py_UCS4 *target, PyObject *src, Py_UCS4 dflt)
|
||||||
*target = '\0';
|
*target = '\0';
|
||||||
if (src != Py_None) {
|
if (src != Py_None) {
|
||||||
Py_ssize_t len;
|
Py_ssize_t len;
|
||||||
len = PyUnicode_GetSize(src);
|
len = PyUnicode_GetLength(src);
|
||||||
if (len > 1) {
|
if (len > 1) {
|
||||||
PyErr_Format(PyExc_TypeError,
|
PyErr_Format(PyExc_TypeError,
|
||||||
"\"%s\" must be an 1-character string",
|
"\"%s\" must be an 1-character string",
|
||||||
|
|
|
@ -1080,7 +1080,7 @@ make_Zreplacement(PyObject *object, PyObject *tzinfoarg)
|
||||||
PyObject *tzinfo = get_tzinfo_member(object);
|
PyObject *tzinfo = get_tzinfo_member(object);
|
||||||
PyObject *Zreplacement = PyUnicode_FromStringAndSize(NULL, 0);
|
PyObject *Zreplacement = PyUnicode_FromStringAndSize(NULL, 0);
|
||||||
_Py_IDENTIFIER(replace);
|
_Py_IDENTIFIER(replace);
|
||||||
|
|
||||||
if (Zreplacement == NULL)
|
if (Zreplacement == NULL)
|
||||||
return NULL;
|
return NULL;
|
||||||
if (tzinfo == Py_None || tzinfo == NULL)
|
if (tzinfo == Py_None || tzinfo == NULL)
|
||||||
|
@ -2673,7 +2673,7 @@ date_format(PyDateTime_Date *self, PyObject *args)
|
||||||
return NULL;
|
return NULL;
|
||||||
|
|
||||||
/* if the format is zero length, return str(self) */
|
/* if the format is zero length, return str(self) */
|
||||||
if (PyUnicode_GetSize(format) == 0)
|
if (PyUnicode_GetLength(format) == 0)
|
||||||
return PyObject_Str((PyObject *)self);
|
return PyObject_Str((PyObject *)self);
|
||||||
|
|
||||||
return _PyObject_CallMethodId((PyObject *)self, &PyId_strftime, "O", format);
|
return _PyObject_CallMethodId((PyObject *)self, &PyId_strftime, "O", format);
|
||||||
|
|
|
@ -33,7 +33,7 @@ static int
|
||||||
convert_to_OSType(PyObject *v, OSType *pr)
|
convert_to_OSType(PyObject *v, OSType *pr)
|
||||||
{
|
{
|
||||||
uint32_t tmp;
|
uint32_t tmp;
|
||||||
if (!PyUnicode_Check(v) || PyUnicode_GetSize(v) != 4) {
|
if (!PyUnicode_Check(v) || PyUnicode_GetLength(v) != 4) {
|
||||||
PyErr_SetString(PyExc_TypeError,
|
PyErr_SetString(PyExc_TypeError,
|
||||||
"OSType arg must be string of 4 chars");
|
"OSType arg must be string of 4 chars");
|
||||||
return 0;
|
return 0;
|
||||||
|
|
|
@ -730,7 +730,7 @@ stringio_init(stringio *self, PyObject *args, PyObject *kwds)
|
||||||
and copy it */
|
and copy it */
|
||||||
self->string_size = 0;
|
self->string_size = 0;
|
||||||
if (value && value != Py_None)
|
if (value && value != Py_None)
|
||||||
value_len = PyUnicode_GetSize(value);
|
value_len = PyUnicode_GetLength(value);
|
||||||
else
|
else
|
||||||
value_len = 0;
|
value_len = 0;
|
||||||
if (value_len > 0) {
|
if (value_len > 0) {
|
||||||
|
|
|
@ -2144,7 +2144,7 @@ textiowrapper_seek(textio *self, PyObject *args)
|
||||||
textiowrapper_set_decoded_chars(self, decoded);
|
textiowrapper_set_decoded_chars(self, decoded);
|
||||||
|
|
||||||
/* Skip chars_to_skip of the decoded characters. */
|
/* Skip chars_to_skip of the decoded characters. */
|
||||||
if (PyUnicode_GetSize(self->decoded_chars) < cookie.chars_to_skip) {
|
if (PyUnicode_GetLength(self->decoded_chars) < cookie.chars_to_skip) {
|
||||||
PyErr_SetString(PyExc_IOError, "can't restore logical file position");
|
PyErr_SetString(PyExc_IOError, "can't restore logical file position");
|
||||||
goto fail;
|
goto fail;
|
||||||
}
|
}
|
||||||
|
@ -2208,7 +2208,7 @@ textiowrapper_tell(textio *self, PyObject *args)
|
||||||
goto fail;
|
goto fail;
|
||||||
|
|
||||||
if (self->decoder == NULL || self->snapshot == NULL) {
|
if (self->decoder == NULL || self->snapshot == NULL) {
|
||||||
assert (self->decoded_chars == NULL || PyUnicode_GetSize(self->decoded_chars) == 0);
|
assert (self->decoded_chars == NULL || PyUnicode_GetLength(self->decoded_chars) == 0);
|
||||||
return posobj;
|
return posobj;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -2941,7 +2941,7 @@ _PyBytes_FormatLong(PyObject *val, int flags, int prec, int type,
|
||||||
PyErr_BadInternalCall();
|
PyErr_BadInternalCall();
|
||||||
return NULL;
|
return NULL;
|
||||||
}
|
}
|
||||||
llen = PyUnicode_GetSize(result);
|
llen = PyUnicode_GetLength(result);
|
||||||
if (llen > INT_MAX) {
|
if (llen > INT_MAX) {
|
||||||
PyErr_SetString(PyExc_ValueError,
|
PyErr_SetString(PyExc_ValueError,
|
||||||
"string too large in _PyBytes_FormatLong");
|
"string too large in _PyBytes_FormatLong");
|
||||||
|
|
|
@ -1273,7 +1273,7 @@ PyUnicodeEncodeError_GetStart(PyObject *exc, Py_ssize_t *start)
|
||||||
if (!obj)
|
if (!obj)
|
||||||
return -1;
|
return -1;
|
||||||
*start = ((PyUnicodeErrorObject *)exc)->start;
|
*start = ((PyUnicodeErrorObject *)exc)->start;
|
||||||
size = PyUnicode_GET_SIZE(obj);
|
size = PyUnicode_GET_LENGTH(obj);
|
||||||
if (*start<0)
|
if (*start<0)
|
||||||
*start = 0; /*XXX check for values <0*/
|
*start = 0; /*XXX check for values <0*/
|
||||||
if (*start>=size)
|
if (*start>=size)
|
||||||
|
@ -1341,7 +1341,7 @@ PyUnicodeEncodeError_GetEnd(PyObject *exc, Py_ssize_t *end)
|
||||||
if (!obj)
|
if (!obj)
|
||||||
return -1;
|
return -1;
|
||||||
*end = ((PyUnicodeErrorObject *)exc)->end;
|
*end = ((PyUnicodeErrorObject *)exc)->end;
|
||||||
size = PyUnicode_GET_SIZE(obj);
|
size = PyUnicode_GET_LENGTH(obj);
|
||||||
if (*end<1)
|
if (*end<1)
|
||||||
*end = 1;
|
*end = 1;
|
||||||
if (*end>size)
|
if (*end>size)
|
||||||
|
|
|
@ -4784,7 +4784,7 @@ _PyUnicode_AsUTF8String(PyObject *unicode, const char *errors)
|
||||||
if (PyBytes_Check(rep))
|
if (PyBytes_Check(rep))
|
||||||
repsize = PyBytes_GET_SIZE(rep);
|
repsize = PyBytes_GET_SIZE(rep);
|
||||||
else
|
else
|
||||||
repsize = PyUnicode_GET_SIZE(rep);
|
repsize = PyUnicode_GET_LENGTH(rep);
|
||||||
|
|
||||||
if (repsize > 4) {
|
if (repsize > 4) {
|
||||||
Py_ssize_t offset;
|
Py_ssize_t offset;
|
||||||
|
@ -8187,7 +8187,7 @@ charmap_encoding_error(
|
||||||
Py_DECREF(repunicode);
|
Py_DECREF(repunicode);
|
||||||
return -1;
|
return -1;
|
||||||
}
|
}
|
||||||
repsize = PyUnicode_GET_SIZE(repunicode);
|
repsize = PyUnicode_GET_LENGTH(repunicode);
|
||||||
data = PyUnicode_DATA(repunicode);
|
data = PyUnicode_DATA(repunicode);
|
||||||
kind = PyUnicode_KIND(repunicode);
|
kind = PyUnicode_KIND(repunicode);
|
||||||
for (index = 0; index < repsize; index++) {
|
for (index = 0; index < repsize; index++) {
|
||||||
|
|
|
@ -86,12 +86,11 @@ _PyWin_FindRegisteredModule(PyObject *moduleName,
|
||||||
suffix = PyUnicode_FromString(fdp->suffix);
|
suffix = PyUnicode_FromString(fdp->suffix);
|
||||||
if (suffix == NULL)
|
if (suffix == NULL)
|
||||||
return NULL;
|
return NULL;
|
||||||
wsuffix = PyUnicode_AsUnicode(suffix);
|
wsuffix = PyUnicode_AsUnicodeAndSize(suffix, &extLen);
|
||||||
if (wsuffix == NULL) {
|
if (wsuffix == NULL) {
|
||||||
Py_DECREF(suffix);
|
Py_DECREF(suffix);
|
||||||
return NULL;
|
return NULL;
|
||||||
}
|
}
|
||||||
extLen = PyUnicode_GET_SIZE(suffix);
|
|
||||||
if ((Py_ssize_t)modNameSize > extLen &&
|
if ((Py_ssize_t)modNameSize > extLen &&
|
||||||
_wcsnicmp(pathBuf + ((Py_ssize_t)modNameSize-extLen-1),
|
_wcsnicmp(pathBuf + ((Py_ssize_t)modNameSize-extLen-1),
|
||||||
wsuffix,
|
wsuffix,
|
||||||
|
|
|
@ -203,13 +203,13 @@ normalize_module(PyObject *filename)
|
||||||
|
|
||||||
mod_str = _PyUnicode_AsString(filename);
|
mod_str = _PyUnicode_AsString(filename);
|
||||||
if (mod_str == NULL)
|
if (mod_str == NULL)
|
||||||
return NULL;
|
return NULL;
|
||||||
len = PyUnicode_GetSize(filename);
|
len = PyUnicode_GetLength(filename);
|
||||||
if (len < 0)
|
if (len < 0)
|
||||||
return NULL;
|
return NULL;
|
||||||
if (len >= 3 &&
|
if (len >= 3 &&
|
||||||
strncmp(mod_str + (len - 3), ".py", 3) == 0) {
|
strncmp(mod_str + (len - 3), ".py", 3) == 0) {
|
||||||
module = PyUnicode_FromStringAndSize(mod_str, len-3);
|
module = PyUnicode_Substring(filename, 0, len-3);
|
||||||
}
|
}
|
||||||
else {
|
else {
|
||||||
module = filename;
|
module = filename;
|
||||||
|
@ -506,7 +506,7 @@ setup_context(Py_ssize_t stack_level, PyObject **filename, int *lineno,
|
||||||
if (PyUnicode_READY(*filename))
|
if (PyUnicode_READY(*filename))
|
||||||
goto handle_error;
|
goto handle_error;
|
||||||
|
|
||||||
len = PyUnicode_GetSize(*filename);
|
len = PyUnicode_GetLength(*filename);
|
||||||
kind = PyUnicode_KIND(*filename);
|
kind = PyUnicode_KIND(*filename);
|
||||||
data = PyUnicode_DATA(*filename);
|
data = PyUnicode_DATA(*filename);
|
||||||
|
|
||||||
|
@ -690,7 +690,7 @@ warnings_warn_explicit(PyObject *self, PyObject *args, PyObject *kwds)
|
||||||
}
|
}
|
||||||
|
|
||||||
/* Split the source into lines. */
|
/* Split the source into lines. */
|
||||||
source_list = PyObject_CallMethodObjArgs(source,
|
source_list = PyObject_CallMethodObjArgs(source,
|
||||||
PyId_splitlines.object,
|
PyId_splitlines.object,
|
||||||
NULL);
|
NULL);
|
||||||
Py_DECREF(source);
|
Py_DECREF(source);
|
||||||
|
|
Loading…
Reference in New Issue