bpo-33718: regrtest keeps filters to re-run fails (GH-7291)

* No longer clear filters, like --match, to re-run failed tests in
  verbose mode (-w option).
* Tests result: always indicate if tests have been interrupted.
* Enhance tests summary
This commit is contained in:
Victor Stinner 2018-06-01 00:48:57 +02:00 committed by GitHub
parent 5601321886
commit 9e24930dfd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 22 additions and 17 deletions

View File

@ -282,7 +282,6 @@ class Regrtest:
self.ns.verbose = True
self.ns.failfast = False
self.ns.verbose3 = False
self.ns.match_tests = None
print()
print("Re-running failed tests in verbose mode")
@ -313,7 +312,7 @@ class Regrtest:
return
print()
print("== Tests result ==")
print("== Tests result: %s ==" % self.get_tests_result())
if self.interrupted:
print()
@ -324,11 +323,6 @@ class Regrtest:
print(count(len(omitted), "test"), "omitted:")
printlist(omitted)
if self.rerun:
print()
print(count(len(self.rerun), "test"), "re-run tests:")
printlist(self.rerun)
if self.good and not self.ns.quiet:
print()
if (not self.bad
@ -361,6 +355,11 @@ class Regrtest:
print(count(len(self.skipped), "test"), "skipped:")
printlist(self.skipped)
if self.rerun:
print()
print("%s:" % count(len(self.rerun), "re-run test"))
printlist(self.rerun)
def run_tests_sequential(self):
if self.ns.trace:
import trace
@ -445,6 +444,21 @@ class Regrtest:
% (locale.getpreferredencoding(False),
sys.getfilesystemencoding()))
def get_tests_result(self):
result = []
if self.bad:
result.append("FAILURE")
elif self.ns.fail_env_changed and self.environment_changed:
result.append("ENV CHANGED")
if self.interrupted:
result.append("INTERRUPTED")
if not result:
result.append("SUCCESS")
return ', '.join(result)
def run_tests(self):
# For a partial run, we do not need to clutter the output.
if (self.ns.header
@ -486,16 +500,7 @@ class Regrtest:
print()
duration = time.monotonic() - self.start_time
print("Total duration: %s" % format_duration(duration))
if self.bad:
result = "FAILURE"
elif self.interrupted:
result = "INTERRUPTED"
elif self.ns.fail_env_changed and self.environment_changed:
result = "ENV CHANGED"
else:
result = "SUCCESS"
print("Tests result: %s" % result)
print("Tests result: %s" % self.get_tests_result())
if self.ns.runleaks:
os.system("leaks %d" % os.getpid())