Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

Address an coverity issue. Coverity was complaining about a line that's fine, 

but an earlier line checked for v != NULL unnecessarily.
This commit is contained in:
Guido van Rossum 2006-03-07 18:31:44 +00:00
parent ec73cd4b1a
commit 9d7855076a
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Python/pythonrun.c
View File

@ -1026,6 +1026,7 @@ PyErr_PrintEx(int set_sys_last_vars)
PyErr_NormalizeException(&exception, &v, &tb); PyErr_NormalizeException(&exception, &v, &tb);
if (exception == NULL) if (exception == NULL)
return; return;
/* Now we know v != NULL too */
if (set_sys_last_vars) { if (set_sys_last_vars) {
PySys_SetObject("last_type", exception); PySys_SetObject("last_type", exception);
PySys_SetObject("last_value", v); PySys_SetObject("last_value", v);
@ -1034,7 +1035,7 @@ PyErr_PrintEx(int set_sys_last_vars)
hook = PySys_GetObject("excepthook"); hook = PySys_GetObject("excepthook");
if (hook) { if (hook) {
PyObject *args = PyTuple_Pack(3, PyObject *args = PyTuple_Pack(3,
exception, v ? v : Py_None, tb ? tb : Py_None); exception, v, tb ? tb : Py_None);
PyObject *result = PyEval_CallObject(hook, args); PyObject *result = PyEval_CallObject(hook, args);
if (result == NULL) { if (result == NULL) {
PyObject *exception2, *v2, *tb2; PyObject *exception2, *v2, *tb2;