Check return value of PyLong_FromLong(X509_get_version()). It might be NULL if

X509_get_version() grows beyond our small int cache. CID 1058279
2013-07-26 15:51:35 +02:00 · 2013-07-26 15:51:35 +02:00 · 9bfcaa6fb3
parent dd6f3899f7 5962bef8aa
commit 9bfcaa6fb3
1 changed files with 2 additions and 0 deletions
--- a/Modules/_ssl.c
+++ b/Modules/_ssl.c
@ -937,6 +937,8 @@ _decode_certificate(X509 *certificate) {
    Py_DECREF(issuer);

    version = PyLong_FromLong(X509_get_version(certificate) + 1);
+    if (version == NULL)
+        goto fail0;
    if (PyDict_SetItemString(retval, "version", version) < 0) {
        Py_DECREF(version);
        goto fail0;