Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

bpo-24658: os.read() reuses _PY_READ_MAX (GH-10657) 

os_read_impl() now also truncates the size to _PY_READ_MAX
on macOS, to avoid to allocate a larger buffer even if _Py_read() is
limited to _PY_READ_MAX bytes (ex: INT_MAX on macOS).
This commit is contained in:
Victor Stinner 2018-11-22 15:03:40 +01:00 committed by GitHub
parent 4d73ae7761
commit 9a0d7a7648
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Modules/posixmodule.c
View File

@ -8410,11 +8410,7 @@ os_read_impl(PyObject *module, int fd, Py_ssize_t length)
return posix_error(); return posix_error();
} }
#ifdef MS_WINDOWS length = Py_MIN(length, _PY_READ_MAX);
/* On Windows, the count parameter of read() is an int */
if (length > INT_MAX)
length = INT_MAX;
#endif
buffer = PyBytes_FromStringAndSize((char *)NULL, length); buffer = PyBytes_FromStringAndSize((char *)NULL, length);
if (buffer == NULL) if (buffer == NULL)