diff --git a/Lib/test/test_builtin.py b/Lib/test/test_builtin.py index 7b3c054d5eb..185d8f794b2 100644 --- a/Lib/test/test_builtin.py +++ b/Lib/test/test_builtin.py @@ -160,6 +160,10 @@ class BuiltinTest(unittest.TestCase): self.assertRaises(TypeError, __import__, 1, 2, 3, 4) self.assertRaises(ValueError, __import__, '') self.assertRaises(TypeError, __import__, 'sys', name='sys') + # Relative import outside of a package with no __package__ or __spec__ (bpo-37409). + self.assertRaises(ImportError, __import__, '', + {'__package__': None, '__spec__': None, '__name__': '__main__'}, + locals={}, fromlist=('foo',), level=1) # embedded null character self.assertRaises(ModuleNotFoundError, __import__, 'string\x00') diff --git a/Lib/test/test_import/__init__.py b/Lib/test/test_import/__init__.py index f167c84f1b2..13d04815da7 100644 --- a/Lib/test/test_import/__init__.py +++ b/Lib/test/test_import/__init__.py @@ -772,6 +772,11 @@ class RelativeImportTests(unittest.TestCase): ns = dict(__package__=object()) self.assertRaises(TypeError, check_relative) + def test_parentless_import_shadowed_by_global(self): + # Test as if this were done from the REPL where this error most commonly occurs (bpo-37409). + script_helper.assert_python_failure('-W', 'ignore', '-c', + "foo = 1; from . import foo") + def test_absolute_import_without_future(self): # If explicit relative import syntax is used, then do not try # to perform an absolute import in the face of failure. diff --git a/Misc/ACKS b/Misc/ACKS index 63189984e64..d37d2bdcc43 100644 --- a/Misc/ACKS +++ b/Misc/ACKS @@ -975,6 +975,7 @@ Alain Leufroy Mark Levinson Mark Levitt Ivan Levkivskyi +Ben Lewis William Lewis Akira Li Robert Li diff --git a/Misc/NEWS.d/next/Core and Builtins/2019-08-06-23-39-05.bpo-37409.1qwzn2.rst b/Misc/NEWS.d/next/Core and Builtins/2019-08-06-23-39-05.bpo-37409.1qwzn2.rst new file mode 100644 index 00000000000..9cfa7154802 --- /dev/null +++ b/Misc/NEWS.d/next/Core and Builtins/2019-08-06-23-39-05.bpo-37409.1qwzn2.rst @@ -0,0 +1,2 @@ +Ensure explicit relative imports from interactive sessions and scripts (having no parent package) always raise ImportError, rather than treating the current module as the package. +Patch by Ben Lewis. diff --git a/Python/import.c b/Python/import.c index 41c2f34f12c..5be4d196a35 100644 --- a/Python/import.c +++ b/Python/import.c @@ -1646,23 +1646,20 @@ resolve_name(PyThreadState *tstate, PyObject *name, PyObject *globals, int level if (dot == -2) { goto error; } - - if (dot >= 0) { - PyObject *substr = PyUnicode_Substring(package, 0, dot); - if (substr == NULL) { - goto error; - } - Py_SETREF(package, substr); + else if (dot == -1) { + goto no_parent_error; } + PyObject *substr = PyUnicode_Substring(package, 0, dot); + if (substr == NULL) { + goto error; + } + Py_SETREF(package, substr); } } last_dot = PyUnicode_GET_LENGTH(package); if (last_dot == 0) { - _PyErr_SetString(tstate, PyExc_ImportError, - "attempted relative import " - "with no known parent package"); - goto error; + goto no_parent_error; } for (level_up = 1; level_up < level; level_up += 1) { @@ -1688,6 +1685,11 @@ resolve_name(PyThreadState *tstate, PyObject *name, PyObject *globals, int level Py_DECREF(base); return abs_name; + no_parent_error: + _PyErr_SetString(tstate, PyExc_ImportError, + "attempted relative import " + "with no known parent package"); + error: Py_XDECREF(package); return NULL;