Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

gh-87804: Fix the refleak in error handling of `_pystatvfs_fromstructstatfs` (#115335) 

It was the macro expansion! Sorry!
This commit is contained in:
Nikita Sobolev 2024-02-12 19:27:27 +03:00 committed by GitHub
parent 91822018ee
commit 91bf01d4b1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
Modules/posixmodule.c
View File

@ -12916,14 +12916,15 @@ _pystatvfs_fromstructstatfs(PyObject *module, struct statfs st) {
_Static_assert(sizeof(st.f_blocks) == sizeof(long long), "assuming large file");
#define SET_ITEM(v, index, item) \
do { \
if (item == NULL) { \
Py_DECREF(v); \
return NULL; \
} \
PyStructSequence_SET_ITEM(v, index, item); \
} while (0) \
#define SET_ITEM(SEQ, INDEX, EXPR) \
do { \
PyObject *obj = (EXPR); \
if (obj == NULL) { \
Py_DECREF((SEQ)); \
return NULL; \
} \
PyStructSequence_SET_ITEM((SEQ), (INDEX), obj); \
} while (0)
SET_ITEM(v, 0, PyLong_FromLong((long) st.f_iosize));
SET_ITEM(v, 1, PyLong_FromLong((long) st.f_bsize));