Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

bpo-45919: Remove out of date comment (GH-30090)

This commit is contained in:
Dong-hee Na 2021-12-14 10:31:41 +09:00 committed by GitHub
parent 121f1f893a
commit 9130a4d620
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Python/pylifecycle.c
View File

@ -2166,13 +2166,15 @@ is_valid_fd(int fd)
some platforms.
fcntl(fd, F_GETFD) is even faster, because it only checks the process table.
It is preferred over dup() when available, since it cannot fail with the
"too many open files" error (EMFILE).
bpo-30225: On macOS Tiger, when stdout is redirected to a pipe and the other
side of the pipe is closed, dup(1) succeed, whereas fstat(1, &st) fails with
EBADF. FreeBSD has similar issue (bpo-32849).
Only use dup() on platforms where dup() is enough to detect invalid FD in
corner cases: on Linux and Windows (bpo-32849).
Only use dup() on Linux where dup() is enough to detect invalid FD
(bpo-32849).
*/
if (fd < 0) {
return 0;