From 8c2fd09f365e082cfceb29afdf38953cdd670946 Mon Sep 17 00:00:00 2001 From: Pablo Galindo Salgado Date: Tue, 18 Jan 2022 11:13:00 +0000 Subject: [PATCH] bpo-46339: Include clarification on assert in 'get_error_line_from_tokenizer_buffers' (#30545) --- Parser/pegen_errors.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Parser/pegen_errors.c b/Parser/pegen_errors.c index bffae8532ca..f348ac3000d 100644 --- a/Parser/pegen_errors.c +++ b/Parser/pegen_errors.c @@ -254,6 +254,9 @@ get_error_line_from_tokenizer_buffers(Parser *p, Py_ssize_t lineno) for (int i = 0; i < relative_lineno - 1; i++) { char *new_line = strchr(cur_line, '\n') + 1; + // The assert is here for debug builds but the conditional that + // follows is there so in release builds we do not crash at the cost + // to report a potentially wrong line. assert(new_line != NULL && new_line < p->tok->inp); if (new_line == NULL || new_line >= p->tok->inp) { break;