Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

_testmultiphase: Fix possible ref leak (GH-22881) 

This is just test code, but sometimes external contributors reference the code snippets from test code.
`PyModule_AddObject` should be handled in the proper way.

https://docs.python.org/3/c-api/module.html#c.PyModule_AddObject
This commit is contained in:
Dong-hee Na 2020-10-22 18:44:18 +09:00 committed by GitHub
parent c8ba47b551
commit 8a9463f2d4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Modules/_testmultiphase.c
View File

@ -359,6 +359,7 @@ static int execfunc(PyObject *m)
goto fail;
}
if (PyModule_AddObject(m, "Example", temp) != 0) {
Py_DECREF(temp);
goto fail;
}
@ -369,6 +370,7 @@ static int execfunc(PyObject *m)
goto fail;
}
if (PyModule_AddObject(m, "error", temp) != 0) {
Py_DECREF(temp);
goto fail;
}
@ -378,6 +380,7 @@ static int execfunc(PyObject *m)
goto fail;
}
if (PyModule_AddObject(m, "Str", temp) != 0) {
Py_DECREF(temp);
goto fail;
}
@ -807,6 +810,7 @@ meth_state_access_exec(PyObject *m)
return -1;
}
if (PyModule_AddObject(m, "StateAccessType", temp) != 0) {
Py_DECREF(temp);
return -1;
}