mirror of https://github.com/python/cpython
gh-117657: Fix file descriptor race in test_socket.py (#123697)
This commit is contained in:
parent
5a4fb7ea1c
commit
8a46a2ec50
|
@ -4806,15 +4806,13 @@ class InterruptedSendTimeoutTest(InterruptedTimeoutBase,
|
|||
|
||||
|
||||
class TCPCloserTest(ThreadedTCPSocketTest):
|
||||
|
||||
def testClose(self):
|
||||
conn, addr = self.serv.accept()
|
||||
conn.close()
|
||||
conn, _ = self.serv.accept()
|
||||
|
||||
sd = self.cli
|
||||
read, write, err = select.select([sd], [], [], 1.0)
|
||||
self.assertEqual(read, [sd])
|
||||
self.assertEqual(sd.recv(1), b'')
|
||||
read, _, _ = select.select([conn], [], [], support.SHORT_TIMEOUT)
|
||||
self.assertEqual(read, [conn])
|
||||
self.assertEqual(conn.recv(1), b'x')
|
||||
conn.close()
|
||||
|
||||
# Calling close() many times should be safe.
|
||||
conn.close()
|
||||
|
@ -4822,7 +4820,10 @@ class TCPCloserTest(ThreadedTCPSocketTest):
|
|||
|
||||
def _testClose(self):
|
||||
self.cli.connect((HOST, self.port))
|
||||
time.sleep(1.0)
|
||||
self.cli.send(b'x')
|
||||
read, _, _ = select.select([self.cli], [], [], support.SHORT_TIMEOUT)
|
||||
self.assertEqual(read, [self.cli])
|
||||
self.assertEqual(self.cli.recv(1), b'')
|
||||
|
||||
|
||||
class BasicSocketPairTest(SocketPairTest):
|
||||
|
|
|
@ -15,8 +15,6 @@ race:set_allocator_unlocked
|
|||
# These entries are for warnings that trigger in a library function, as called
|
||||
# by a CPython function.
|
||||
|
||||
# https://gist.github.com/swtaarrs/8e0e365e1d9cecece3269a2fb2f2b8b8
|
||||
race:sock_recv_impl
|
||||
# https://gist.github.com/swtaarrs/08dfe7883b4c975c31ecb39388987a67
|
||||
race:free_threadstate
|
||||
|
||||
|
|
Loading…
Reference in New Issue