From 84271bb34fa2a0d4609caade9b07f06cc83a8626 Mon Sep 17 00:00:00 2001 From: Guido van Rossum Date: Thu, 30 May 2002 15:41:56 +0000 Subject: [PATCH] SF #558432: Prevent Annoying ' ' from readline (Holker Krekel). readline in all python versions is configured to append a 'space' character for a successful completion. But for almost all python expressions 'space' is not wanted (see coding conventions PEP 8). For example if you have a function 'longfunction' and you type 'longf' you get 'longfunction ' as a completion. note the unwanted space at the end. The patch fixes this behaviour by setting readline's append_character to '\0' which means don't append anything. This doesn't work with readline < 2.1 (AFAIK nowadays readline2.2 is in good use). An alternative approach would be to make the append_character accessable from python so that modules like the rlcompleter.py can set it to '\0'. [Ed.: I think expecting readline >= 2.2 is fine. If a completer wants another character they can append that to the keyword in the list.] --- Modules/readline.c | 1 + 1 file changed, 1 insertion(+) diff --git a/Modules/readline.c b/Modules/readline.c index 2d75ace8577..6850b016bda 100644 --- a/Modules/readline.c +++ b/Modules/readline.c @@ -573,6 +573,7 @@ setup_readline(void) rl_completer_word_break_characters = strdup(" \t\n`~!@#$%^&*()-=+[{]}\\|;:'\",<>/?"); /* All nonalphanums except '.' */ + rl_completion_append_character ='\0'; begidx = PyInt_FromLong(0L); endidx = PyInt_FromLong(0L);