Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

closes bpo-34468: Objects/rangeobject.c: Fix an always-false condition in range_repr() (GH-8880) 

Also, propagate the error from PyNumber_AsSsize_t() because we don't care
only about OverflowError which is not reported if the second argument is NULL.

Reported by Svace static analyzer.
This commit is contained in:
Alexey Izbyshev 2018-08-24 07:39:45 +03:00 committed by Benjamin Peterson
parent 2b824b2538
commit 7ecae3ca0b
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Objects/rangeobject.c
View File

@ -575,11 +575,11 @@ range_repr(rangeobject *r)
Py_ssize_t istep; Py_ssize_t istep;
/* Check for special case values for printing. We don't always /* Check for special case values for printing. We don't always
need the step value. We don't care about errors need the step value. We don't care about overflow. */
(it means overflow), so clear the errors. */
istep = PyNumber_AsSsize_t(r->step, NULL); istep = PyNumber_AsSsize_t(r->step, NULL);
if (istep != 1 || (istep == -1 && PyErr_Occurred())) { if (istep == -1 && PyErr_Occurred()) {
PyErr_Clear(); assert(!PyErr_ExceptionMatches(PyExc_OverflowError));
return NULL;
} }
if (istep == 1) if (istep == 1)