gh-113939: Frame clear, clear locals (#113940)

This commit is contained in:
Albert Zeyer 2024-01-31 20:14:44 +01:00 committed by GitHub
parent b905fad838
commit 78c254582b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 27 additions and 0 deletions

View File

@ -55,6 +55,28 @@ class ClearTest(unittest.TestCase):
# The reference was released by .clear()
self.assertIs(None, wr())
def test_clear_locals_after_f_locals_access(self):
# see gh-113939
class C:
pass
wr = None
def inner():
nonlocal wr
c = C()
wr = weakref.ref(c)
1/0
try:
inner()
except ZeroDivisionError as exc:
support.gc_collect()
self.assertIsNotNone(wr())
print(exc.__traceback__.tb_next.tb_frame.f_locals)
exc.__traceback__.tb_next.tb_frame.clear()
support.gc_collect()
self.assertIsNone(wr())
def test_clear_does_not_clear_specials(self):
class C:
pass

View File

@ -0,0 +1,4 @@
frame.clear():
Clear frame.f_locals as well, and not only the fast locals.
This is relevant once frame.f_locals was accessed,
which would contain also references to all the locals.

View File

@ -926,6 +926,7 @@ frame_tp_clear(PyFrameObject *f)
Py_CLEAR(locals[i]);
}
f->f_frame->stacktop = 0;
Py_CLEAR(f->f_frame->f_locals);
return 0;
}