Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

Fix math.factorial KeyboardInterrupt segfault. Thanks Amaury for report and diagnosis.

This commit is contained in:
Mark Dickinson 2012-10-25 10:46:28 +01:00
parent 837cd06d36
commit 76464494bc
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Misc/NEWS
View File

@ -132,6 +132,9 @@ Core and Builtins
Library Library
------- -------
- Issue #16305: Fix a segmentation fault occurring when interrupting
math.factorial.
- Issue #14398: Fix size truncation and overflow bugs in the bz2 module. - Issue #14398: Fix size truncation and overflow bugs in the bz2 module.
- Issue #16220: wsgiref now always calls close() on an iterable response. - Issue #16220: wsgiref now always calls close() on an iterable response.

7
Modules/mathmodule.c
View File

@ -1330,14 +1330,13 @@ factorial_odd_part(unsigned long n)
Py_DECREF(outer); Py_DECREF(outer);
outer = tmp; outer = tmp;
} }
Py_DECREF(inner);
goto done; return outer;
error: error:
Py_DECREF(outer); Py_DECREF(outer);
done:
Py_DECREF(inner); Py_DECREF(inner);
return outer; return NULL;
} }
/* Lookup table for small factorial values */ /* Lookup table for small factorial values */