Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

Optimize PyList_AsTuple(). Improve cache performance by doing the 

pointer copy and object increment in one pass.  For small lists,
save the overhead of the call to memcpy() -- this comes up in
calls like f(*listcomp).
This commit is contained in:
Raymond Hettinger 2007-12-15 00:07:25 +00:00
parent c67a15d865
commit 6c87af5d87
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Objects/listobject.c
View File

@ -2186,7 +2186,7 @@ PyObject *
PyList_AsTuple(PyObject *v)
{
PyObject *w;
PyObject **p;
PyObject **p, **q;
Py_ssize_t n;
if (v == NULL || !PyList_Check(v)) {
PyErr_BadInternalCall();
@ -2197,12 +2197,12 @@ PyList_AsTuple(PyObject *v)
if (w == NULL)
return NULL;
p = ((PyTupleObject *)w)->ob_item;
memcpy((void *)p,
(void *)((PyListObject *)v)->ob_item,
n*sizeof(PyObject *));
q = ((PyListObject *)v)->ob_item;
while (--n >= 0) {
Py_INCREF(*p);
Py_INCREF(*q);
*p = *q;
p++;
q++;
}
return w;
}