Issue #16856: Fix a segmentation fault from calling repr() on a dict with

a key whose repr raise an exception.
This commit is contained in:
Serhiy Storchaka 2013-01-04 12:39:34 +02:00
parent bf064b3911
commit 6c83e739d7
2 changed files with 4 additions and 1 deletions

View File

@ -12,6 +12,9 @@ What's New in Python 3.3.1?
Core and Builtins
-----------------
- Issue #16856: Fix a segmentation fault from calling repr() on a dict with
a key whose repr raise an exception.
- Issue #16367: Fix FileIO.readall() on Windows for files larger than 2 GB.
- Issue #16455: On FreeBSD and Solaris, if the locale is C, the

View File

@ -10672,7 +10672,7 @@ PyUnicode_Append(PyObject **p_left, PyObject *right)
return;
}
left = *p_left;
if (right == NULL || !PyUnicode_Check(left)) {
if (right == NULL || left == NULL || !PyUnicode_Check(left)) {
if (!PyErr_Occurred())
PyErr_BadInternalCall();
goto error;