Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

#14832: 'first' now really refers to first arg in unittest assertItemsEqual 

This appears to have been a mixup introduced when we switched from
'expected/actual' to 'first/second'.  The problem doesn't exist
in the corresponding assertCountEqual method in Python3.
This commit is contained in:
R David Murray 2012-05-16 14:01:03 -04:00
parent 019935f615
commit 6949392b56
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Lib/unittest/case.py
View File

@ -872,7 +872,7 @@ class TestCase(object):
- [0, 1, 1] and [1, 0, 1] compare equal. - [0, 1, 1] and [1, 0, 1] compare equal.
- [0, 0, 1] and [0, 1] compare unequal. - [0, 0, 1] and [0, 1] compare unequal.
""" """
first_seq, second_seq = list(actual_seq), list(expected_seq) first_seq, second_seq = list(expected_seq), list(actual_seq)
with warnings.catch_warnings(): with warnings.catch_warnings():
if sys.py3kwarning: if sys.py3kwarning:
# Silence Py3k warning raised during the sorting # Silence Py3k warning raised during the sorting

3
Misc/NEWS
View File

@ -60,6 +60,9 @@ Core and Builtins
Library Library
------- -------
- Issue #14832: fixed the order of the argument references in the error
message produced by unittest's assertItemsEqual.
- Issue #14829: Fix bisect issues under 64-bit Windows. - Issue #14829: Fix bisect issues under 64-bit Windows.
- Issue #14777: tkinter may return undecoded UTF-8 bytes as a string when - Issue #14777: tkinter may return undecoded UTF-8 bytes as a string when