Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

gh-113655: Revert extra stack reserve in PGO builds unless UseExtraStackReserve=true (GH-114263)

This commit is contained in:
Steve Dower 2024-01-22 21:19:16 +00:00 committed by GitHub
parent 412920a41e
commit 665b8f365e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
PCbuild/python.vcxproj
View File

@ -99,7 +99,7 @@
<StackReserveSize Condition="$(Configuration) == 'Debug'">12000000</StackReserveSize> <StackReserveSize Condition="$(Configuration) == 'Debug'">12000000</StackReserveSize>
<StackReserveSize Condition="$(Configuration) == 'PGInstrument'">12000000</StackReserveSize> <StackReserveSize Condition="$(Configuration) == 'PGInstrument'">12000000</StackReserveSize>
<!-- HACK: Need additional memory to avoid crashing until gh-113655 is fixed --> <!-- HACK: Need additional memory to avoid crashing until gh-113655 is fixed -->
<StackReserveSize Condition="$(Configuration) == 'PGUpdate'">3000000</StackReserveSize> <StackReserveSize Condition="$(Configuration) == 'PGUpdate' and $(UseExtraStackReserve) == 'true'">3000000</StackReserveSize>
</Link> </Link>
</ItemDefinitionGroup> </ItemDefinitionGroup>
<ItemGroup> <ItemGroup>

2
PCbuild/pythonw.vcxproj
View File

@ -94,7 +94,7 @@
<StackReserveSize Condition="$(Configuration) == 'Debug'">12000000</StackReserveSize> <StackReserveSize Condition="$(Configuration) == 'Debug'">12000000</StackReserveSize>
<StackReserveSize Condition="$(Configuration) == 'PGInstrument'">12000000</StackReserveSize> <StackReserveSize Condition="$(Configuration) == 'PGInstrument'">12000000</StackReserveSize>
<!-- HACK: Need additional memory to avoid crashing until gh-113655 is fixed --> <!-- HACK: Need additional memory to avoid crashing until gh-113655 is fixed -->
<StackReserveSize Condition="$(Configuration) == 'PGUpdate'">3000000</StackReserveSize> <StackReserveSize Condition="$(Configuration) == 'PGUpdate' and $(UseExtraStackReserve) == 'true'">3000000</StackReserveSize>
</Link> </Link>
</ItemDefinitionGroup> </ItemDefinitionGroup>
<ItemGroup> <ItemGroup>