Issue #9128: Fix validation of class decorators in parser module.

This commit is contained in:
Mark Dickinson 2010-07-04 16:28:57 +00:00
parent e9123efa21
commit 644bef795b
3 changed files with 19 additions and 8 deletions

View File

@ -156,6 +156,14 @@ class RoundtripLegalSyntaxTestCase(unittest.TestCase):
def test_class_defs(self):
self.check_suite("class foo():pass")
self.check_suite("@class_decorator\n"
"class foo():pass")
self.check_suite("@class_decorator(arg)\n"
"class foo():pass")
self.check_suite("@decorator1\n"
"@decorator2\n"
"class foo():pass")
def test_import_from_statement(self):
self.check_suite("from sys.path import *")

View File

@ -81,6 +81,8 @@ C-API
Library
-------
- Issue #9128: Fix validation of class decorators in parser module.
- Issue #7673: Fix security vulnerability (CVE-2010-2089) in the audioop
module, ensure that the input string length is a multiple of the frame size

View File

@ -2679,14 +2679,15 @@ validate_funcdef(node *tree)
static int
validate_decorated(node *tree)
{
int nch = NCH(tree);
int ok = (validate_ntype(tree, decorated)
&& (nch == 2)
&& validate_decorators(RCHILD(tree, -2))
&& (validate_funcdef(RCHILD(tree, -1))
|| validate_class(RCHILD(tree, -1)))
);
return ok;
int nch = NCH(tree);
int ok = (validate_ntype(tree, decorated)
&& (nch == 2)
&& validate_decorators(RCHILD(tree, -2)));
if (TYPE(RCHILD(tree, -1)) == funcdef)
ok = ok && validate_funcdef(RCHILD(tree, -1));
else
ok = ok && validate_class(RCHILD(tree, -1));
return ok;
}
static int