From 5a5c81a0e9550eaab92c9817259dee5a52f69871 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Marc-Andr=C3=A9=20Lemburg?= <mal@egenix.com>
Date: Fri, 7 Jul 2000 13:46:42 +0000
Subject: [PATCH] Added new API PyUnicode_FromEncodedObject() which supports
 decoding objects including instance objects.

The old API PyUnicode_FromObject() is still available as shortcut.
---
 Include/unicodeobject.h | 18 ++++++++++++++
 Objects/unicodeobject.c | 55 ++++++++++++++++++++++++++++++++++++-----
 2 files changed, 67 insertions(+), 6 deletions(-)

diff --git a/Include/unicodeobject.h b/Include/unicodeobject.h
index b9840dd4f6f..38f787b7888 100644
--- a/Include/unicodeobject.h
+++ b/Include/unicodeobject.h
@@ -297,6 +297,24 @@ extern DL_IMPORT(int) PyUnicode_Resize(
 
 */
 
+extern DL_IMPORT(PyObject*) PyUnicode_FromEncodedObject(
+    register PyObject *obj, 	/* Object */
+    const char *encoding,       /* encoding */
+    const char *errors          /* error handling */
+    );
+
+/* Shortcut for PyUnicode_FromEncodedObject(obj, NULL, "strict");
+   which results in using the default encoding as basis for 
+   decoding the object.
+
+   Coerces obj to an Unicode object and return a reference with
+   *incremented* refcount.
+
+   The API returns NULL in case of an error. The caller is responsible
+   for decref'ing the returned objects.
+
+*/
+
 extern DL_IMPORT(PyObject*) PyUnicode_FromObject(
     register PyObject *obj 	/* Object */
     );
diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c
index e94cef2b453..266600744c7 100644
--- a/Objects/unicodeobject.c
+++ b/Objects/unicodeobject.c
@@ -355,17 +355,48 @@ int PyUnicode_AsWideChar(PyUnicodeObject *unicode,
 #endif
 
 PyObject *PyUnicode_FromObject(register PyObject *obj)
+{
+    return PyUnicode_FromEncodedObject(obj, NULL, "strict");
+}
+
+PyObject *PyUnicode_FromEncodedObject(register PyObject *obj,
+				      const char *encoding,
+				      const char *errors)
 {
     const char *s;
     int len;
+    int owned = 0;
+    PyObject *v;
     
     if (obj == NULL) {
 	PyErr_BadInternalCall();
 	return NULL;
     }
-    else if (PyUnicode_Check(obj)) {
+
+    /* Coerce object */
+    if (PyInstance_Check(obj)) {
+	PyObject *func;
+	func = PyObject_GetAttrString(obj, "__str__");
+	if (func == NULL) {
+	    PyErr_SetString(PyExc_TypeError,
+		  "coercing to Unicode: instance doesn't define __str__");
+	    return NULL;
+	}
+	obj = PyEval_CallObject(func, NULL);
+	Py_DECREF(func);
+	if (obj == NULL)
+	    return NULL;
+	owned = 1;
+    }
+    if (PyUnicode_Check(obj)) {
 	Py_INCREF(obj);
-	return obj;
+	v = obj;
+	if (encoding) {
+	    PyErr_SetString(PyExc_TypeError,
+			    "decoding Unicode is not supported");
+	    return NULL;
+	}
+	goto done;
     }
     else if (PyString_Check(obj)) {
 	s = PyString_AS_STRING(obj);
@@ -376,14 +407,26 @@ PyObject *PyUnicode_FromObject(register PyObject *obj)
 	   case of a TypeError. */
 	if (PyErr_ExceptionMatches(PyExc_TypeError))
 	    PyErr_SetString(PyExc_TypeError,
-			    "coercing to Unicode: need string or charbuffer");
-	return NULL;
+		  "coercing to Unicode: need string or buffer");
+	goto onError;
     }
+
+    /* Convert to Unicode */
     if (len == 0) {
 	Py_INCREF(unicode_empty);
-	return (PyObject *)unicode_empty;
+	v = (PyObject *)unicode_empty;
     }
-    return PyUnicode_Decode(s, len, NULL, "strict");
+    else 
+	v = PyUnicode_Decode(s, len, encoding, errors);
+ done:
+    if (owned)
+	Py_DECREF(obj);
+    return v;
+
+ onError:
+    if (owned)
+	Py_DECREF(obj);
+    return NULL;
 }
 
 PyObject *PyUnicode_Decode(const char *s,