Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

Fix Coverity #159. 

This code was broken if save() returned a negative number since i contained
a boolean value and then we compared i < 0 which should never be true.

Will backport (assuming it's necessary)
This commit is contained in:
Neal Norwitz 2007-10-05 05:01:38 +00:00
parent 3adac21762
commit 5a29dd30e0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Modules/cPickle.c
View File

@ -2249,7 +2249,7 @@ save_reduce(Picklerobject *self, PyObject *args, PyObject *ob)
Py_INCREF(temp); Py_INCREF(temp);
PyTuple_SET_ITEM(newargtup, i-1, temp); PyTuple_SET_ITEM(newargtup, i-1, temp);
} }
i = save(self, newargtup, 0) < 0; i = save(self, newargtup, 0);
Py_DECREF(newargtup); Py_DECREF(newargtup);
if (i < 0) if (i < 0)
return -1; return -1;