mirror of https://github.com/python/cpython
Issue #13019: Fix potential reference leaks in bytearray.extend().
Patch by Suman Saha.
This commit is contained in:
parent
165a2c2e27
commit
58bb82e7b4
|
@ -10,6 +10,9 @@ What's New in Python 3.2.4
|
|||
Core and Builtins
|
||||
-----------------
|
||||
|
||||
- Issue #13019: Fix potential reference leaks in bytearray.extend(). Patch
|
||||
by Suman Saha.
|
||||
|
||||
- Issue #14378: Fix compiling ast.ImportFrom nodes with a "__future__" string as
|
||||
the module name that was not interned.
|
||||
|
||||
|
|
|
@ -2234,8 +2234,10 @@ bytearray_extend(PyByteArrayObject *self, PyObject *arg)
|
|||
}
|
||||
|
||||
bytearray_obj = PyByteArray_FromStringAndSize(NULL, buf_size);
|
||||
if (bytearray_obj == NULL)
|
||||
if (bytearray_obj == NULL) {
|
||||
Py_DECREF(it);
|
||||
return NULL;
|
||||
}
|
||||
buf = PyByteArray_AS_STRING(bytearray_obj);
|
||||
|
||||
while ((item = PyIter_Next(it)) != NULL) {
|
||||
|
@ -2268,8 +2270,10 @@ bytearray_extend(PyByteArrayObject *self, PyObject *arg)
|
|||
return NULL;
|
||||
}
|
||||
|
||||
if (bytearray_setslice(self, Py_SIZE(self), Py_SIZE(self), bytearray_obj) == -1)
|
||||
if (bytearray_setslice(self, Py_SIZE(self), Py_SIZE(self), bytearray_obj) == -1) {
|
||||
Py_DECREF(bytearray_obj);
|
||||
return NULL;
|
||||
}
|
||||
Py_DECREF(bytearray_obj);
|
||||
|
||||
Py_RETURN_NONE;
|
||||
|
|
Loading…
Reference in New Issue