mirror of https://github.com/python/cpython
PyFunction_Call() did not check the result of PyObject_Repr() for NULL, and
should just avoid calling it in the first place to avoid waiting for a repr of a large object like a dict or list. The result of PyObject_Repr() was being leaked as well. Bugfix candidate!
This commit is contained in:
parent
d2364e8e2d
commit
573395a7a8
|
@ -1660,8 +1660,8 @@ PyObject_Call(PyObject *func, PyObject *arg, PyObject *kw)
|
||||||
"NULL result without error in PyObject_Call");
|
"NULL result without error in PyObject_Call");
|
||||||
return result;
|
return result;
|
||||||
}
|
}
|
||||||
PyErr_Format(PyExc_TypeError, "object is not callable: %s",
|
PyErr_Format(PyExc_TypeError, "'%s' object is not callable",
|
||||||
PyString_AS_STRING(PyObject_Repr(func)));
|
func->ob_type->tp_name);
|
||||||
return NULL;
|
return NULL;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue