From 571cefd8c7933f4917739dde43171558f109d63c Mon Sep 17 00:00:00 2001 From: "Miss Islington (bot)" <31488909+miss-islington@users.noreply.github.com> Date: Tue, 25 Jun 2024 19:40:05 +0200 Subject: [PATCH] [3.13] gh-120155: Fix Coverity issue in parse_string() (GH-120997) (#121005) gh-120155: Fix Coverity issue in parse_string() (GH-120997) (cherry picked from commit 769aea332940f03c3e5b1ad9badd6635c1ac992a) Co-authored-by: Victor Stinner --- Parser/string_parser.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Parser/string_parser.c b/Parser/string_parser.c index bacfd815441..93ad92b8235 100644 --- a/Parser/string_parser.c +++ b/Parser/string_parser.c @@ -229,9 +229,14 @@ _PyPegen_parse_string(Parser *p, Token *t) PyErr_BadInternalCall(); return NULL; } + /* Skip the leading quote char. */ s++; len = strlen(s); + // gh-120155: 's' contains at least the trailing quote, + // so the code '--len' below is safe. + assert(len >= 1); + if (len > INT_MAX) { PyErr_SetString(PyExc_OverflowError, "string to parse is too long"); return NULL;