mirror of https://github.com/python/cpython
bpo-19696: Replace deprecated method in "test_import_pkg.py" (GH-14466)
Replacing the deprecated method "random.choose" to "random.choice" was technically not part of the original issue. However, it was discussed in the talk page and involved one of the files being moved. I assumed this was too minor to justify the creation of a separate issue. Also, I added my name to the contributors list in Misc/ACKS. This will be my third PR to cpython, forgot to do it in the previous ones. https://bugs.python.org/issue19696
This commit is contained in:
parent
53c2143440
commit
56ec4f1fde
|
@ -14,7 +14,7 @@ class TestImport(unittest.TestCase):
|
|||
def __init__(self, *args, **kw):
|
||||
self.package_name = 'PACKAGE_'
|
||||
while self.package_name in sys.modules:
|
||||
self.package_name += random.choose(string.ascii_letters)
|
||||
self.package_name += random.choice(string.ascii_letters)
|
||||
self.module_name = self.package_name + '.foo'
|
||||
unittest.TestCase.__init__(self, *args, **kw)
|
||||
|
||||
|
@ -60,7 +60,7 @@ class TestImport(unittest.TestCase):
|
|||
# ...make up a variable name that isn't bound in __builtins__
|
||||
var = 'a'
|
||||
while var in dir(__builtins__):
|
||||
var += random.choose(string.ascii_letters)
|
||||
var += random.choice(string.ascii_letters)
|
||||
|
||||
# ...make a module that just contains that
|
||||
self.rewrite_file(var)
|
||||
|
|
|
@ -1572,6 +1572,7 @@ Tage Stabell-Kulo
|
|||
Quentin Stafford-Fraser
|
||||
Frank Stajano
|
||||
Joel Stanley
|
||||
Kyle Stanley
|
||||
Anthony Starks
|
||||
David Steele
|
||||
Oliver Steele
|
||||
|
|
|
@ -0,0 +1 @@
|
|||
Replace deprecated method "random.choose" with "random.choice" in "test_pkg_import.py".
|
Loading…
Reference in New Issue