From 53835e92d315340444e3dd083b3f69a590b00e07 Mon Sep 17 00:00:00 2001 From: Zackery Spytz Date: Sun, 28 Oct 2018 22:55:20 -0600 Subject: [PATCH] Fix a possible "double decref" in termios.tcgetattr(). (GH-10194) --- Modules/termios.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Modules/termios.c b/Modules/termios.c index b4aa77f8976..7601b68afda 100644 --- a/Modules/termios.c +++ b/Modules/termios.c @@ -119,11 +119,11 @@ termios_tcgetattr(PyObject *self, PyObject *args) PyList_SetItem(v, 3, PyLong_FromLong((long)mode.c_lflag)); PyList_SetItem(v, 4, PyLong_FromLong((long)ispeed)); PyList_SetItem(v, 5, PyLong_FromLong((long)ospeed)); - PyList_SetItem(v, 6, cc); - if (PyErr_Occurred()){ + if (PyErr_Occurred()) { Py_DECREF(v); goto err; } + PyList_SetItem(v, 6, cc); return v; err: Py_DECREF(cc);